nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-24 13:57:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: skip legacy batch ledger lookups when no legacy entry exists (backport #59110) (#59111)

Browse Source 
* perf: skip legacy batch ledger lookups when no legacy entry exists (#59110)

* perf: skip legacy batch ledger lookups when no legacy entry exists

(cherry picked from commit 0130d287f6)

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
This commit is contained in:
mergify[bot]
2026-09-21 13:37:46 +05:30
committed by GitHub
parent 75c1a7fd69
commit 4af1b0db4e
1 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
erpnext/stock/deprecated_serial_batch.py
View File

@@ -12,6 +12,37 @@ from pypika.terms import ExistsCriterion
from erpnext.deprecation_dumpster import deprecated
@frappe.request_cache
def has_legacy_batch_ledgers(item_code: str, warehouse: str) -> bool:
"""`False` when no Stock Ledger Entry of the item and warehouse uses the
denormalized `batch_no` field.
Batches are tracked through the Serial and Batch Bundle since v15, so this is
`False` for most of the item and warehouse combinations and the expensive
aggregates (`FOR UPDATE`) below can be skipped without reading the ledger. The
probe is an index only scan on the `batch_no, item_code, warehouse` index,
`is_cancelled` is intentionally left out of it to keep it so, an item with only
cancelled legacy ledgers simply falls back to the aggregate.
Cached for the request, nothing creates a legacy ledger midway.
"""
sle = frappe.qb.DocType("Stock Ledger Entry")
return bool(
frappe.qb.from_(sle)
.select(sle.batch_no)
.where(
sle.batch_no.isnotnull()
& (sle.batch_no != "")
& (sle.item_code == item_code)
& (sle.warehouse == warehouse)
)
.limit(1)
.run()
)
class DeprecatedSerialNoValuation:
@deprecated(
"erpnext.stock.serial_batch_bundle.SerialNoValuation.calculate_stock_value_from_deprecarated_ledgers",
@@ -121,7 +152,9 @@ class DeprecatedBatchNoValuation:
def get_sle_for_batches(self):
from erpnext.stock.utils import get_combine_datetime
if not self.batchwise_valuation_batches:
if not self.batchwise_valuation_batches or not has_legacy_batch_ledgers(
self.sle.item_code, self.sle.warehouse
):
return []
sle = frappe.qb.DocType("Stock Ledger Entry")
@@ -285,6 +318,9 @@ class DeprecatedBatchNoValuation:
def set_balance_value_from_sl_entries(self) -> None:
from erpnext.stock.utils import get_combine_datetime
if not has_legacy_batch_ledgers(self.sle.item_code, self.sle.warehouse):
return
sle = frappe.qb.DocType("Stock Ledger Entry")
batch = frappe.qb.DocType("Batch")