nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 06:01:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(buying): insert default Supplier Scorecard records with ignore_if_duplicate (Postgres)

Browse Source 
make_default_records inserted Scorecard Variable/Standing rows in a loop and swallowed DuplicateEntryError (frappe.NameError). On Postgres the failed insert poisons the txn so the next iteration's insert raises InFailedSqlTransaction. insert(ignore_if_duplicate=True) emits ON CONFLICT DO NOTHING, never poisoning the txn. No-op on MariaDB.
This commit is contained in:
Mihir Kandoi
2026-06-29 22:38:01 +05:30
parent 1dde2b5f1e
commit 4a572311bc
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
View File

@@ -405,16 +405,10 @@ def get_default_scorecard_standing():
def make_default_records():
install_variable_docs = get_default_scorecard_variables()
for d in install_variable_docs:
try:
d["doctype"] = "Supplier Scorecard Variable"
frappe.get_doc(d).insert()
except frappe.NameError:
pass
d["doctype"] = "Supplier Scorecard Variable"
frappe.get_doc(d).insert(ignore_if_duplicate=True)
install_standing_docs = get_default_scorecard_standing()
for d in install_standing_docs:
try:
d["doctype"] = "Supplier Scorecard Standing"
frappe.get_doc(d).insert()
except frappe.NameError:
pass
d["doctype"] = "Supplier Scorecard Standing"
frappe.get_doc(d).insert(ignore_if_duplicate=True)