nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 16:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Tests

Browse Source
This commit is contained in:
marination
2023-05-17 14:23:44 +05:30
parent dbf7a479b6
commit 4a14e9ea4e
2 changed files with 35 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/bank_transaction/auto_match_party.py
View File

@@ -105,7 +105,7 @@ class AutoMatchbyAccountIBAN:
or_filters["iban"] = self.bank_party_iban or_filters["iban"] = self.bank_party_iban
party_result = frappe.db.get_all( party_result = frappe.db.get_all(
"Bank Account", or_filters=or_filters, pluck="name", limit_page_length=1 "Bank Account", or_filters=or_filters, pluck="party", limit_page_length=1
) )
if party == "Employee" and not party_result: if party == "Employee" and not party_result:

40
erpnext/accounts/doctype/bank_transaction/test_auto_match_party.py
View File

@@ -146,22 +146,50 @@ class TestAutoMatchParty(FrappeTestCase):
self.assertEqual(doc_2.party, "Amazon") self.assertEqual(doc_2.party, "Amazon")
def create_supplier_for_match(supplier_name="John Doe & Co.", account_no=None, iban=None): def create_supplier_for_match(supplier_name="John Doe & Co.", iban=None, account_no=None):
if frappe.db.exists("Supplier", supplier_name): if frappe.db.exists("Supplier", {"supplier_name": supplier_name}):
frappe.db.set_value("Supplier", supplier_name, {"bank_account_no": account_no, "iban": iban}) # Update related Bank Account details
if not (iban or account_no):
return
frappe.db.set_value(
dt="Bank Account",
dn={"party": supplier_name},
field={"iban": iban, "bank_account_no": account_no},
)
return return
frappe.get_doc( # Create Supplier and Bank Account for the same
supplier = frappe.get_doc(
{ {
"doctype": "Supplier", "doctype": "Supplier",
"supplier_name": supplier_name, "supplier_name": supplier_name,
"supplier_group": "Services", "supplier_group": "Services",
"supplier_type": "Company", "supplier_type": "Company",
"bank_account_no": account_no,
"iban": iban,
} }
).insert() ).insert()
if not frappe.db.exists("Bank", "TestBank"):
frappe.get_doc(
{
"doctype": "Bank",
"bank_name": "TestBank",
}
).insert(ignore_if_duplicate=True)
if not frappe.db.exists("Bank Account", supplier.name + " - " + "TestBank"):
frappe.get_doc(
{
"doctype": "Bank Account",
"account_name": supplier.name,
"bank": "TestBank",
"iban": iban,
"bank_account_no": account_no,
"party_type": "Supplier",
"party": supplier.name,
}
).insert()
def create_bank_transaction( def create_bank_transaction(
description=None, description=None,