nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-31 23:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: skip stock expense GL entries for non-stock items (#57519)

Browse Source 
* fix: skip stock expense gl entries for non stock items

* test: use a leaf expense account for the service item invoice
This commit is contained in:
rohitwaghchaure
2026-07-28 13:00:32 +05:30
committed by GitHub
parent 2f07dfc474
commit 4a0a1db17e
3 changed files with 52 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/controllers/buying_controller.py
View File

@@ -355,7 +355,14 @@ class BuyingController(SubcontractingController):
if self.doctype == "Purchase Invoice" and not self.update_stock:
return
stock_items = self.get_stock_items()
for row in self.items:
# A service item holds no stock value, so there is nothing to book against it - and it
# must not make the expense accounts mandatory either.
if row.item_code not in stock_items:
continue
details = self.get_validated_purchase_expense_details(row.item_code)
if not details:
continue
@@ -364,6 +371,10 @@ class BuyingController(SubcontractingController):
if row.landed_cost_voucher_amount:
amount -= flt(row.landed_cost_voucher_amount, row.precision("base_amount"))
if not amount:
# GL Entry rejects a row with neither a debit nor a credit.
continue
self.add_gl_entry(
gl_entries=gl_entries,
account=details.purchase_expense_account,