nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-13 14:41:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: honor overproduction allowance in duplicate entry check

Browse Source 
Compare already-entered finished good qty against the work order qty plus
the configured overproduction percentage, mirroring the submit-time guard
in work_order/services/status.py, so a save is never rejected that the
submission contract would accept.
This commit is contained in:
Mihir Kandoi
2026-08-11 12:33:59 +05:30
parent 1665873fc9
commit 492ee05727
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/stock/doctype/stock_entry/services/manufacturing.py
View File

@@ -436,7 +436,7 @@ class ManufactureStockEntry(BaseManufactureStockEntry):
)
def check_duplicate_entry_for_work_order(self):
"""Block another manufacture entry once existing entries already cover the full work order qty."""
"""Block another manufacture entry once existing entries already cover the work order qty plus allowance."""
if not self.wo_doc or self.wo_doc.track_semi_finished_goods:
return
@@ -453,7 +453,11 @@ class ManufactureStockEntry(BaseManufactureStockEntry):
if not other_entries:
return
if self.get_fg_qty_already_entered(other_entries) >= flt(self.wo_doc.qty):
allowance_percentage = flt(
frappe.db.get_single_value("Manufacturing Settings", "overproduction_percentage_for_work_order")
)
allowed_qty = flt(self.wo_doc.qty) + (allowance_percentage / 100 * flt(self.wo_doc.qty))
if self.get_fg_qty_already_entered(other_entries) >= allowed_qty:
frappe.throw(
_("Stock Entries already created for Work Order {0}: {1}").format(
self.doc.work_order, ", ".join(other_entries)