From 491987b8d3330695d8fa6a6b3ca152f7fb683c28 Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Tue, 13 Apr 2021 17:47:56 +0530 Subject: [PATCH] fix: except einvoice loading error seperately --- erpnext/regional/india/e_invoice/utils.py | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/erpnext/regional/india/e_invoice/utils.py b/erpnext/regional/india/e_invoice/utils.py index 7db376a10be..1ca3fff4d1e 100644 --- a/erpnext/regional/india/e_invoice/utils.py +++ b/erpnext/regional/india/e_invoice/utils.py @@ -465,19 +465,22 @@ def make_einvoice(invoice): try: einvoice = safe_json_load(einvoice) einvoice = santize_einvoice_fields(einvoice) - validate_totals(einvoice) - except Exception: - log_error(einvoice) - link_to_error_list = 'Error Log' - frappe.throw( - _('An error occurred while creating e-invoice for {}. Please check {} for more information.').format( - invoice.name, link_to_error_list), - title=_('E Invoice Creation Failed') - ) + show_link_to_error_log(invoice, einvoice) + + validate_totals(einvoice) return einvoice +def show_link_to_error_log(invoice, einvoice): + err_log = log_error(einvoice) + link_to_error_log = get_link_to_form('Error Log', err_log.name, 'Error Log') + frappe.throw( + _('An error occurred while creating e-invoice for {}. Please check {} for more information.').format( + invoice.name, link_to_error_log), + title=_('E Invoice Creation Failed') + ) + def log_error(data=None): if isinstance(data, six.string_types): data = json.loads(data)