nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-20 13:39:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #44339 from vishakhdesai/hd-ticket-20084

Browse Source 
fix: move `validate_total_debit_and_credit` from`validate` to`on_submit` in Journal Entry
This commit is contained in:
ruthra kumar
2024-12-03 18:08:59 +05:30
committed by GitHub
parent 88b0af1696 c3ace82db8
commit 483fd124fc
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/doctype/journal_entry/journal_entry.py
View File

@@ -127,9 +127,6 @@ class JournalEntry(AccountsController):
self.set_amounts_in_company_currency() self.set_amounts_in_company_currency()
self.validate_debit_credit_amount() self.validate_debit_credit_amount()
self.set_total_debit_credit() self.set_total_debit_credit()
# Do not validate while importing via data import
if not frappe.flags.in_import:
self.validate_total_debit_and_credit()
if not frappe.flags.is_reverse_depr_entry: if not frappe.flags.is_reverse_depr_entry:
self.validate_against_jv() self.validate_against_jv()
@@ -184,6 +181,11 @@ class JournalEntry(AccountsController):
else: else:
return self._cancel() return self._cancel()
def before_submit(self):
# Do not validate while importing via data import
if not frappe.flags.in_import:
self.validate_total_debit_and_credit()
def on_submit(self): def on_submit(self):
self.validate_cheque_info() self.validate_cheque_info()
self.check_credit_limit() self.check_credit_limit()