nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 00:44:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use fetch from property for qi template on job card

Browse Source
This commit is contained in:
Diksha Jadhav
2021-11-09 14:21:34 +05:30
parent 6c45f8b2c4
commit 467324c87f
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/manufacturing/doctype/job_card/job_card.json
View File

@@ -410,6 +410,7 @@
"print_hide": 1 "print_hide": 1
}, },
{ {
"fetch_from": "operation.quality_inspection_template",
"fieldname": "quality_inspection_template", "fieldname": "quality_inspection_template",
"fieldtype": "Link", "fieldtype": "Link",
"label": "Quality Inspection Template", "label": "Quality Inspection Template",
@@ -418,7 +419,7 @@
], ],
"is_submittable": 1, "is_submittable": 1,
"links": [], "links": [],
"modified": "2021-11-03 13:46:06.557348", "modified": "2021-11-09 14:07:20.290306",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Manufacturing", "module": "Manufacturing",
"name": "Job Card", "name": "Job Card",

5
erpnext/manufacturing/doctype/job_card/job_card.py
View File

@@ -45,7 +45,6 @@ class JobCard(Document):
self.validate_sequence_id() self.validate_sequence_id()
self.set_sub_operations() self.set_sub_operations()
self.update_sub_operation_status() self.update_sub_operation_status()
self.set_quality_inspection_template()
def set_sub_operations(self): def set_sub_operations(self):
if self.operation: if self.operation:
@@ -293,10 +292,6 @@ class JobCard(Document):
row.completed_time = 0.0 row.completed_time = 0.0
row.completed_qty = 0.0 row.completed_qty = 0.0
def set_quality_inspection_template(self):
qi_template = frappe.db.get_value('Operation', self.operation, 'quality_inspection_template')
self.quality_inspection_template = qi_template
def update_time_logs(self, row): def update_time_logs(self, row):
self.append("time_logs", { self.append("time_logs", {
"from_time": row.planned_start_time, "from_time": row.planned_start_time,