From 44260b469f325770f7764d77a28ac920a8df92c5 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Thu, 6 Aug 2026 20:48:19 +0530 Subject: [PATCH] refactor: remove unreachable UOM conversion in production plan The division by conversion_factor in _adjust_required_qty_for_uom sits directly after frappe.throw inside the same block, so it can never run. It has been dead since commit 2a8cd05b44 (#27278) re-indented it into the throw branch; the actual purchase-UOM conversion happens in _material_request_item_row via _mr_purchase_conversion_factor. --- .../doctype/production_plan/services/material_request.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/manufacturing/doctype/production_plan/services/material_request.py b/erpnext/manufacturing/doctype/production_plan/services/material_request.py index 9e6d26bd963..c9073d5e648 100644 --- a/erpnext/manufacturing/doctype/production_plan/services/material_request.py +++ b/erpnext/manufacturing/doctype/production_plan/services/material_request.py @@ -533,7 +533,6 @@ def _adjust_required_qty_for_uom(row, required_qty): row["purchase_uom"], row["stock_uom"], row.item_code ) ) - required_qty = required_qty / row["conversion_factor"] if frappe.db.get_value("UOM", row["purchase_uom"], "must_be_whole_number"): required_qty = ceil(required_qty)