nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 18:01:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(lead): name the loops in remove_link_from_prospect

Browse Source 
The outer and inner loops both used 'd'; name them linked_prospect and lead
so the prospect/lead iteration reads clearly. No behaviour change.
This commit is contained in:
Nabin Hait
2026-06-22 13:10:29 +05:30
parent 8f69697212
commit 43d2c7335d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/crm/doctype/lead/lead.py
View File

@@ -197,17 +197,17 @@ class Lead(SellingController, CRMNote):
lead_row.db_update() lead_row.db_update()
def remove_link_from_prospect(self): def remove_link_from_prospect(self):
prospects = self.get_linked_prospects() linked_prospects = self.get_linked_prospects()
for d in prospects: for linked_prospect in linked_prospects:
prospect = frappe.get_doc("Prospect", d.parent) prospect = frappe.get_doc("Prospect", linked_prospect.parent)
if len(prospect.get("leads")) == 1: if len(prospect.get("leads")) == 1:
prospect.delete(ignore_permissions=True) prospect.delete(ignore_permissions=True)
else: else:
to_remove = None to_remove = None
for d in prospect.get("leads"): for lead in prospect.get("leads"):
if d.lead == self.name: if lead.lead == self.name:
to_remove = d to_remove = lead
if to_remove: if to_remove:
prospect.remove(to_remove) prospect.remove(to_remove)