nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-19 11:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add permission check for get_item_details (backport #57515) (#57550)

Browse Source 
Co-authored-by: Diptanil Saha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-07-28 20:22:13 +05:30
committed by GitHub
parent 6939d9a76a
commit 41effcf754
3 changed files with 74 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/stock/doctype/item_default/item_default.json
View File

@@ -38,6 +38,7 @@
{ {
"fieldname": "default_warehouse", "fieldname": "default_warehouse",
"fieldtype": "Link", "fieldtype": "Link",
"ignore_user_permissions": 1,
"in_list_view": 1, "in_list_view": 1,
"label": "Default Warehouse", "label": "Default Warehouse",
"options": "Warehouse", "options": "Warehouse",
@@ -63,7 +64,8 @@
"fieldname": "buying_cost_center", "fieldname": "buying_cost_center",
"fieldtype": "Link", "fieldtype": "Link",
"label": "Default Buying Cost Center", "label": "Default Buying Cost Center",
"options": "Cost Center" "options": "Cost Center",
"ignore_user_permissions": 1
}, },
{ {
"fieldname": "default_supplier", "fieldname": "default_supplier",
@@ -90,6 +92,7 @@
"fieldname": "selling_cost_center", "fieldname": "selling_cost_center",
"fieldtype": "Link", "fieldtype": "Link",
"label": "Default Selling Cost Center", "label": "Default Selling Cost Center",
"ignore_user_permissions": 1,
"options": "Cost Center" "options": "Cost Center"
}, },
{ {
@@ -99,12 +102,14 @@
{ {
"fieldname": "income_account", "fieldname": "income_account",
"fieldtype": "Link", "fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Default Income Account", "label": "Default Income Account",
"options": "Account" "options": "Account"
}, },
{ {
"fieldname": "default_discount_account", "fieldname": "default_discount_account",
"fieldtype": "Link", "fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Default Discount Account", "label": "Default Discount Account",
"options": "Account" "options": "Account"
}, },
@@ -123,6 +128,7 @@
"depends_on": "eval: parent.enable_deferred_expense", "depends_on": "eval: parent.enable_deferred_expense",
"fieldname": "deferred_expense_account", "fieldname": "deferred_expense_account",
"fieldtype": "Link", "fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Deferred Expense Account", "label": "Deferred Expense Account",
"options": "Account" "options": "Account"
}, },
@@ -130,6 +136,7 @@
"depends_on": "eval: parent.enable_deferred_revenue", "depends_on": "eval: parent.enable_deferred_revenue",
"fieldname": "deferred_revenue_account", "fieldname": "deferred_revenue_account",
"fieldtype": "Link", "fieldtype": "Link",
"ignore_user_permissions": 1,
"label": "Deferred Revenue Account", "label": "Deferred Revenue Account",
"options": "Account" "options": "Account"
}, },
@@ -140,7 +147,7 @@
], ],
"istable": 1, "istable": 1,
"links": [], "links": [],
"modified": "2025-03-17 13:46:09.719105", "modified": "2026-07-28 15:39:44.848087",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Stock", "module": "Stock",
"name": "Item Default", "name": "Item Default",

217
erpnext/stock/doctype/item_reorder/item_reorder.json
View File

@@ -1,161 +1,72 @@
{ {
"allow_copy": 0, "actions": [],
"allow_import": 0, "autoname": "hash",
"allow_rename": 0, "creation": "2013-03-07 11:42:59",
"autoname": "hash", "doctype": "DocType",
"beta": 0, "document_type": "Setup",
"creation": "2013-03-07 11:42:59", "editable_grid": 1,
"custom": 0, "engine": "InnoDB",
"docstatus": 0, "field_order": [
"doctype": "DocType", "warehouse",
"document_type": "Setup", "warehouse_group",
"editable_grid": 1, "warehouse_reorder_level",
"warehouse_reorder_qty",
"material_request_type"
],
"fields": [ "fields": [
{ {
"allow_on_submit": 0, "columns": 3,
"bold": 0, "fieldname": "warehouse_group",
"collapsible": 0, "fieldtype": "Link",
"fieldname": "warehouse_group", "ignore_user_permissions": 1,
"fieldtype": "Link", "in_list_view": 1,
"hidden": 0, "label": "Check Availability in Warehouse",
"ignore_user_permissions": 0, "options": "Warehouse"
"ignore_xss_filter": 0, },
"in_filter": 0,
"in_list_view": 1,
"label": "Check in (group)",
"length": 0,
"no_copy": 0,
"options": "Warehouse",
"permlevel": 0,
"precision": "",
"print_hide": 0,
"print_hide_if_no_value": 0,
"read_only": 0,
"report_hide": 0,
"reqd": 0,
"search_index": 0,
"set_only_once": 0,
"unique": 0
},
{ {
"allow_on_submit": 0, "columns": 2,
"bold": 0, "fieldname": "warehouse",
"collapsible": 0, "fieldtype": "Link",
"fieldname": "warehouse", "ignore_user_permissions": 1,
"fieldtype": "Link", "in_list_view": 1,
"hidden": 0, "label": "Request for",
"ignore_user_permissions": 0, "options": "Warehouse",
"ignore_xss_filter": 0, "reqd": 1
"in_filter": 0, },
"in_list_view": 1,
"label": "Request for",
"length": 0,
"no_copy": 0,
"options": "Warehouse",
"permlevel": 0,
"print_hide": 0,
"print_hide_if_no_value": 0,
"read_only": 0,
"report_hide": 0,
"reqd": 1,
"search_index": 0,
"set_only_once": 0,
"unique": 0
},
{ {
"allow_on_submit": 0, "fieldname": "warehouse_reorder_level",
"bold": 0, "fieldtype": "Float",
"collapsible": 0, "in_list_view": 1,
"fieldname": "warehouse_reorder_level", "label": "Re-order Level"
"fieldtype": "Float", },
"hidden": 0,
"ignore_user_permissions": 0,
"ignore_xss_filter": 0,
"in_filter": 0,
"in_list_view": 1,
"label": "Re-order Level",
"length": 0,
"no_copy": 0,
"permlevel": 0,
"print_hide": 0,
"print_hide_if_no_value": 0,
"read_only": 0,
"report_hide": 0,
"reqd": 0,
"search_index": 0,
"set_only_once": 0,
"unique": 0
},
{ {
"allow_on_submit": 0, "fieldname": "warehouse_reorder_qty",
"bold": 0, "fieldtype": "Float",
"collapsible": 0, "in_list_view": 1,
"fieldname": "warehouse_reorder_qty", "label": "Re-order Qty"
"fieldtype": "Float", },
"hidden": 0,
"ignore_user_permissions": 0,
"ignore_xss_filter": 0,
"in_filter": 0,
"in_list_view": 1,
"label": "Re-order Qty",
"length": 0,
"no_copy": 0,
"permlevel": 0,
"print_hide": 0,
"print_hide_if_no_value": 0,
"read_only": 0,
"report_hide": 0,
"reqd": 0,
"search_index": 0,
"set_only_once": 0,
"unique": 0
},
{ {
"allow_on_submit": 0, "fieldname": "material_request_type",
"bold": 0, "fieldtype": "Select",
"collapsible": 0, "in_list_view": 1,
"fieldname": "material_request_type", "label": "Material Request Type",
"fieldtype": "Select", "options": "Purchase\nTransfer\nMaterial Issue\nManufacture",
"hidden": 0, "reqd": 1
"ignore_user_permissions": 0,
"ignore_xss_filter": 0,
"in_filter": 0,
"in_list_view": 1,
"label": "Material Request Type",
"length": 0,
"no_copy": 0,
"options": "Purchase\nTransfer\nMaterial Issue\nManufacture",
"permlevel": 0,
"precision": "",
"print_hide": 0,
"print_hide_if_no_value": 0,
"read_only": 0,
"report_hide": 0,
"reqd": 1,
"search_index": 0,
"set_only_once": 0,
"unique": 0
} }
], ],
"hide_heading": 0, "idx": 1,
"hide_toolbar": 0, "in_create": 1,
"idx": 1, "istable": 1,
"image_view": 0, "links": [],
"in_create": 1, "modified": "2026-07-28 17:05:12.778047",
"modified_by": "Administrator",
"is_submittable": 0, "module": "Stock",
"issingle": 0, "name": "Item Reorder",
"istable": 1, "naming_rule": "Random",
"max_attachments": 0, "owner": "Administrator",
"modified": "2023-06-21 15:13:38.270046", "permissions": [],
"modified_by": "Administrator", "row_format": "Dynamic",
"module": "Stock", "sort_field": "creation",
"name": "Item Reorder", "sort_order": "ASC",
"owner": "Administrator", "states": []
"permissions": [], }
"quick_entry": 0,
"read_only": 0,
"read_only_onload": 0,
"sort_order": "ASC",
"track_seen": 0
}

1
erpnext/stock/get_item_details.py
View File

@@ -63,6 +63,7 @@ def get_item_details(args, doc=None, for_validate=False, overwrite_warehouse=Tru
for_validate = process_string_args(for_validate) for_validate = process_string_args(for_validate)
overwrite_warehouse = process_string_args(overwrite_warehouse) overwrite_warehouse = process_string_args(overwrite_warehouse)
item = frappe.get_cached_doc("Item", args.item_code) item = frappe.get_cached_doc("Item", args.item_code)
item.check_permission()
validate_item_details(args, item) validate_item_details(args, item)
if isinstance(doc, str): if isinstance(doc, str):