From 41c93c8832f9f38ac79fba4db8dc80ddec254412 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Wed, 12 Mar 2025 16:05:08 +0530 Subject: [PATCH] =?UTF-8?q?fix:=20return=20None=20if=20document=20does=20n?= =?UTF-8?q?ot=20have=20status=20field=20in=20get=5Fstatus=E2=80=A6=20(#464?= =?UTF-8?q?15)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: return None if document does not have status field in get_status function * chore: add comment --- erpnext/controllers/status_updater.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/erpnext/controllers/status_updater.py b/erpnext/controllers/status_updater.py index 400bd6e5626..df7bc0bb044 100644 --- a/erpnext/controllers/status_updater.py +++ b/erpnext/controllers/status_updater.py @@ -220,7 +220,9 @@ class StatusUpdater(Document): } """ if self.doctype not in status_map: - return {"status": self.status} + return { + "status": self.get("status") + } # sometimes status field is not present on certain DocTypes such as Stock Entry sl = status_map[self.doctype][:] sl.reverse() @@ -562,7 +564,8 @@ class StatusUpdater(Document): target = frappe.get_doc(args["target_parent_dt"], args["name"]) target.update(update_data) # status calculus might depend on it status = target.get_status() - update_data.update(status) + if status.get("status"): + update_data.update(status) target.db_set(update_data, update_modified=update_modified, notify=True) def _update_modified(self, args, update_modified):