nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(regional): rename duplicate Customer fields in Italy setup (backport #50921) (#53398)

Browse Source 
* fix(regional): rename duplicate Customer fields in Italy setup (#50921)

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
(cherry picked from commit c6efc403cd)

# Conflicts:
#	erpnext/patches.txt

* chore: resolve conflicts

---------

Co-authored-by: Solede <lorenzo.caldara@gmail.com>
Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
This commit is contained in:
mergify[bot]
2026-03-12 15:22:22 +00:00
committed by GitHub
parent 0685c0b9ff
commit 41bcf96601
5 changed files with 330 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
erpnext/patches/v15_0/rename_italy_customer_name_fields.py Normal file
View File

@@ -0,0 +1,65 @@
import frappe
def execute():
"""Rename Italy regional custom fields to avoid conflict with standard Customer fields.
The Italy regional setup created custom fields 'first_name' and 'last_name' on Customer
which conflict with the standard read-only fields that fetch from customer_primary_contact.
This patch renames them to 'italy_customer_first_name' and 'italy_customer_last_name'.
"""
# Check if old fields exist and are the Italy regional ones
old_first_name_exists = frappe.db.exists("Custom Field", "Customer-first_name")
old_last_name_exists = frappe.db.exists("Custom Field", "Customer-last_name")
is_italy_first_name = False
is_italy_last_name = False
if old_first_name_exists:
field_doc = frappe.get_doc("Custom Field", "Customer-first_name")
is_italy_first_name = field_doc.depends_on and "customer_type" in field_doc.depends_on
if old_last_name_exists:
field_doc = frappe.get_doc("Custom Field", "Customer-last_name")
is_italy_last_name = field_doc.depends_on and "customer_type" in field_doc.depends_on
# If neither field is the Italy regional one, nothing to do
if not is_italy_first_name and not is_italy_last_name:
return
# Step 1: Delete old Custom Field documents FIRST (to avoid duplicate field validation error)
if is_italy_first_name:
frappe.delete_doc("Custom Field", "Customer-first_name", force=True)
if is_italy_last_name:
frappe.delete_doc("Custom Field", "Customer-last_name", force=True)
# Step 2: Create the new fields and sync database schema
from erpnext.regional.italy.setup import make_custom_fields
make_custom_fields(update=True)
# Step 3: Migrate data from old columns to new columns (if old columns still exist in DB)
# Note: We do NOT drop the first_name/last_name columns because they are standard fields
# in Customer doctype (Read Only fields that fetch from customer_primary_contact).
# The Italy regional setup incorrectly created Custom Fields with the same names.
# We only migrate the data and leave the standard columns intact.
if is_italy_first_name and frappe.db.has_column("Customer", "first_name"):
frappe.db.sql(
"""
UPDATE `tabCustomer`
SET italy_customer_first_name = first_name
WHERE first_name IS NOT NULL AND first_name != ''
AND (italy_customer_first_name IS NULL OR italy_customer_first_name = '')
"""
)
if is_italy_last_name and frappe.db.has_column("Customer", "last_name"):
frappe.db.sql(
"""
UPDATE `tabCustomer`
SET italy_customer_last_name = last_name
WHERE last_name IS NOT NULL AND last_name != ''
AND (italy_customer_last_name IS NULL OR italy_customer_last_name = '')
"""
)