From 3ef6c24f07c49506873fba6b16edec087eff24ec Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Sat, 18 Apr 2026 17:14:49 +0530 Subject: [PATCH] fix: zero valuation rate popup on SI (#54376) --- erpnext/controllers/stock_controller.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 01366d7bcc8..fb863f92947 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -142,14 +142,19 @@ class StockController(AccountsController): ]: for item in self.get("items"): if ( - (item.get("valuation_rate") == 0 or item.get("incoming_rate") == 0) + ( + item.get("valuation_rate") == 0 + or (item.get("incoming_rate") == 0 and self.get("update_stock", 1)) + ) and item.get("allow_zero_valuation_rate") == 0 and frappe.get_cached_value("Item", item.item_code, "is_stock_item") ): frappe.toast( - _( - "Row #{0}: Item {1} has zero rate but 'Allow Zero Valuation Rate' is not enabled." - ).format(item.idx, frappe.bold(item.item_code)), + _("Row #{0}: Item {1} has zero rate but '{2}' is not enabled.").format( + item.idx, + frappe.bold(item.item_code), + item.meta.get_label("allow_zero_valuation_rate"), + ), indicator="orange", )