nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-19 19:37:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: only consider draft and active assets in patch, and allow asset depr schedule to be manually createed

Browse Source
This commit is contained in:
anandbaburajan
2022-12-23 11:01:18 +05:30
parent 246d3b4075
commit 3e91a56c19
2 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/patches/v15_0/create_asset_depreciation_schedules_from_assets.py
View File

@@ -2,7 +2,7 @@ import frappe
def execute():
assets = get_details_of_depreciable_assets()
assets = get_details_of_draft_or_submitted_depreciable_assets()
for asset in assets:
finance_book_rows = get_details_of_asset_finance_books_rows(asset.name)
@@ -32,19 +32,16 @@ def execute():
if asset.docstatus == 1:
asset_depr_schedule_doc.status = "Active"
asset_depr_schedule_doc.submit()
elif asset.docstatus == 2:
asset_depr_schedule_doc.status = "Cancelled"
asset_depr_schedule_doc.submit()
asset_depr_schedule_doc.cancel()
def get_details_of_depreciable_assets():
def get_details_of_draft_or_submitted_depreciable_assets():
asset = frappe.qb.DocType("Asset")
records = (
frappe.qb.from_(asset)
.select(asset.name, asset.opening_accumulated_depreciation, asset.docstatus)
.where(asset.calculate_depreciation == 1)
.where(asset.docstatus < 2)
).run(as_dict=True)
return records
@@ -76,7 +73,7 @@ def update_depreciation_schedules(asset_name, asset_depr_schedule_name, fb_row_i
depr_schedules = (
frappe.qb.from_(ds)
.select(ds.name)
.where((ds.parent == asset_name) & (int(ds.finance_book_id) == fb_row_idx))
.where((ds.parent == asset_name) & (ds.finance_book_id == str(fb_row_idx)))
).run(as_dict=True)
for idx, depr_schedule in enumerate(depr_schedules, start=1):