nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-17 10:36:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(tests): replace AccountsTestMixin master data setup with direct attribute assignments

Browse Source 
All test classes inheriting AccountsTestMixin that called create_company(),
create_item(), create_customer(), create_supplier(), create_usd_receivable_account(),
and create_usd_payable_account() in setUp() now set instance attributes directly
using master data pre-created by BootStrapTestData, eliminating redundant DB
inserts on every test run.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit 1fda0dfb9b)
This commit is contained in:
ruthra kumar
2026-06-16 17:55:42 +05:30
committed by Mergify
parent 3586df8ed6
commit 3d91e021a3
20 changed files with 103 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/accounts/doctype/advance_payment_ledger_entry/test_advance_payment_ledger_entry.py
View File

@@ -22,10 +22,13 @@ class TestAdvancePaymentLedgerEntry(ERPNextTestSuite, AccountsTestMixin):
""" """
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_usd_receivable_account() self.customer = "_Test Customer"
self.create_usd_payable_account() self.supplier = "_Test Supplier"
self.create_item() self.item = "_Test Item"
self.cash = "Cash - _TC"
self.debtors_usd = "_Test Receivable USD - _TC"
self.creditors_usd = "_Test Payable USD - _TC"
self.clear_old_entries() self.clear_old_entries()
def create_sales_order(self, qty=1, rate=100, currency="INR", do_not_submit=False): def create_sales_order(self, qty=1, rate=100, currency="INR", do_not_submit=False):

6
erpnext/accounts/doctype/bank_reconciliation_tool/test_bank_reconciliation_tool.py
View File

@@ -17,8 +17,10 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestBankReconciliationTool(ERPNextTestSuite, AccountsTestMixin): class TestBankReconciliationTool(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.bank = "HDFC - _TC"
self.debit_to = "Debtors - _TC"
self.clear_old_entries() self.clear_old_entries()
bank_dt = qb.DocType("Bank") bank_dt = qb.DocType("Bank")
qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run() qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()

5
erpnext/accounts/doctype/bank_statement_import_log/test_bank_statement_import_log.py
View File

@@ -26,8 +26,9 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestBankStatementImportLog(ERPNextTestSuite, AccountsTestMixin): class TestBankStatementImportLog(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.bank = "HDFC - _TC"
self.clear_old_entries() self.clear_old_entries()
bank_dt = qb.DocType("Bank") bank_dt = qb.DocType("Bank")
qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run() qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()

7
erpnext/accounts/doctype/bank_transaction_rule/test_bank_transaction_rule.py
View File

@@ -11,8 +11,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestBankTransactionRule(ERPNextTestSuite, AccountsTestMixin): class TestBankTransactionRule(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.bank = "HDFC - _TC"
self.debit_to = "Debtors - _TC"
self.cash = "Cash - _TC"
self.clear_old_entries() self.clear_old_entries()
bank_dt = qb.DocType("Bank") bank_dt = qb.DocType("Bank")
qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run() qb.from_(bank_dt).delete().where(bank_dt.name == "HDFC").run()

9
erpnext/accounts/doctype/exchange_rate_revaluation/test_exchange_rate_revaluation.py
View File

@@ -15,10 +15,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestExchangeRateRevaluation(ERPNextTestSuite, AccountsTestMixin): class TestExchangeRateRevaluation(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_usd_receivable_account() self.item = "_Test Item"
self.create_item() self.customer = "_Test Customer"
self.create_customer() self.cost_center = "Main - _TC"
self.debtors_usd = "_Test Receivable USD - _TC"
self.clear_old_entries() self.clear_old_entries()
self.set_system_and_company_settings() self.set_system_and_company_settings()

6
erpnext/accounts/doctype/ledger_health/test_ledger_health.py
View File

@@ -12,8 +12,10 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestLedgerHealth(ERPNextTestSuite, AccountsTestMixin): class TestLedgerHealth(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.debit_to = "Debtors - _TC"
self.income_account = "Sales - _TC"
self.configure_monitoring_tool() self.configure_monitoring_tool()
self.clear_old_entries() self.clear_old_entries()

3
erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py
View File

@@ -21,8 +21,7 @@ class TestProcessStatementOfAccounts(ERPNextTestSuite, AccountsTestMixin):
letterhead.is_default = 0 letterhead.is_default = 0
letterhead.save() letterhead.save()
self.create_company() self.company = "_Test Company"
self.create_customer()
self.create_customer(customer_name="Other Customer") self.create_customer(customer_name="Other Customer")
self.clear_old_entries() self.clear_old_entries()
self.si = create_sales_invoice() self.si = create_sales_invoice()

13
erpnext/accounts/doctype/unreconcile_payment/test_unreconcile_payment.py
View File

@@ -16,11 +16,14 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestUnreconcilePayment(ERPNextTestSuite, AccountsTestMixin): class TestUnreconcilePayment(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_supplier() self.supplier = "_Test Supplier"
self.create_usd_receivable_account() self.item = "_Test Item"
self.create_item() self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
self.cash = "Cash - _TC"
self.debtors_usd = "_Test Receivable USD - _TC"
self.clear_old_entries() self.clear_old_entries()
def create_sales_invoice(self, do_not_submit=False): def create_sales_invoice(self, do_not_submit=False):

9
erpnext/accounts/report/accounts_payable/test_accounts_payable.py
View File

@@ -9,11 +9,10 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsPayable(ERPNextTestSuite, AccountsTestMixin): class TestAccountsPayable(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.item = "_Test Item"
self.create_item() self.supplier = "_Test Supplier USD"
self.create_supplier(currency="USD", supplier_name="Test Supplier2") self.creditors_usd = "_Test Payable USD - _TC"
self.create_usd_payable_account()
def test_accounts_payable_for_foreign_currency_supplier(self): def test_accounts_payable_for_foreign_currency_supplier(self):
pi = self.create_purchase_invoice(do_not_submit=True) pi = self.create_purchase_invoice(do_not_submit=True)

15
erpnext/accounts/report/accounts_receivable/test_accounts_receivable.py
View File

@@ -12,10 +12,17 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin): class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.company_abbr = "_TC"
self.create_item() self.customer = "_Test Customer"
self.create_usd_receivable_account() self.item = "_Test Item"
self.cost_center = "Main - _TC"
self.warehouse = "Stores - _TC"
self.income_account = "Sales - _TC"
self.expense_account = "Cost of Goods Sold - _TC"
self.debit_to = "Debtors - _TC"
self.cash = "Cash - _TC"
self.debtors_usd = "_Test Receivable USD - _TC"
self.clear_old_entries() self.clear_old_entries()
def create_sales_invoice(self, no_payment_schedule=False, do_not_submit=False, **args): def create_sales_invoice(self, no_payment_schedule=False, do_not_submit=False, **args):

8
erpnext/accounts/report/accounts_receivable_summary/test_accounts_receivable_summary.py
View File

@@ -11,9 +11,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin): class TestAccountsReceivable(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.maxDiff = None self.maxDiff = None
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_item() self.item = "_Test Item"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
self.clear_old_entries() self.clear_old_entries()
def test_01_receivable_summary_output(self): def test_01_receivable_summary_output(self):

9
erpnext/accounts/report/customer_ledger_summary/test_customer_ledger_summary.py
View File

@@ -12,9 +12,12 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestCustomerLedgerSummary(ERPNextTestSuite, AccountsTestMixin): class TestCustomerLedgerSummary(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_item() self.item = "_Test Item"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
self.cash = "Cash - _TC"
self.clear_old_entries() self.clear_old_entries()
def create_sales_invoice(self, do_not_submit=False, **args): def create_sales_invoice(self, do_not_submit=False, **args):

12
erpnext/accounts/report/deferred_revenue_and_expense/test_deferred_revenue_and_expense.py
View File

@@ -61,9 +61,15 @@ class TestDeferredRevenueAndExpense(ERPNextTestSuite, AccountsTestMixin):
) )
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer("_Test Customer") self.company_abbr = "_TC"
self.create_supplier("_Test Furniture Supplier") self.customer = "_Test Customer"
self.supplier = "_Test Supplier"
self.warehouse = "Stores - _TC"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
self.income_account = "Sales - _TC"
self.expense_account = "Cost of Goods Sold - _TC"
self.setup_deferred_accounts_and_items() self.setup_deferred_accounts_and_items()
self.clear_old_entries() self.clear_old_entries()

8
erpnext/accounts/report/general_and_payment_ledger_comparison/test_general_and_payment_ledger_comparison.py
View File

@@ -12,7 +12,13 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestGeneralAndPaymentLedger(ERPNextTestSuite, AccountsTestMixin): class TestGeneralAndPaymentLedger(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.debit_to = "Debtors - _TC"
self.expense_account = "Cost of Goods Sold - _TC"
self.cost_center = "Main - _TC"
self.income_account = "Sales - _TC"
self.warehouse = "Stores - _TC"
self.creditors = "Creditors - _TC"
self.cleanup() self.cleanup()
def cleanup(self): def cleanup(self):

6
erpnext/accounts/report/item_wise_purchase_register/test_item_wise_purchase_register.py
View File

@@ -9,9 +9,9 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestItemWisePurchaseRegister(ERPNextTestSuite, AccountsTestMixin): class TestItemWisePurchaseRegister(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_supplier() self.supplier = "_Test Supplier"
self.create_item() self.item = "_Test Item"
def create_purchase_invoice(self, do_not_submit=False): def create_purchase_invoice(self, do_not_submit=False):
pi = make_purchase_invoice( pi = make_purchase_invoice(

8
erpnext/accounts/report/item_wise_sales_register/test_item_wise_sales_register.py
View File

@@ -9,9 +9,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestItemWiseSalesRegister(ERPNextTestSuite, AccountsTestMixin): class TestItemWiseSalesRegister(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_item() self.item = "_Test Item"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
def create_sales_invoice(self, item=None, taxes=None, do_not_submit=False): def create_sales_invoice(self, item=None, taxes=None, do_not_submit=False):
si = create_sales_invoice( si = create_sales_invoice(

8
erpnext/accounts/report/profit_and_loss_statement/test_profit_and_loss_statement.py
View File

@@ -14,9 +14,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestProfitAndLossStatement(ERPNextTestSuite, AccountsTestMixin): class TestProfitAndLossStatement(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_item() self.item = "_Test Item"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
def create_sales_invoice(self, qty=1, rate=150, no_payment_schedule=False, do_not_submit=False): def create_sales_invoice(self, qty=1, rate=150, no_payment_schedule=False, do_not_submit=False):
frappe.set_user("Administrator") frappe.set_user("Administrator")

10
erpnext/accounts/report/sales_register/test_sales_register.py
View File

@@ -10,9 +10,13 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestItemWiseSalesRegister(ERPNextTestSuite, AccountsTestMixin): class TestItemWiseSalesRegister(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_customer() self.customer = "_Test Customer"
self.create_item() self.item = "_Test Item"
self.debit_to = "Debtors - _TC"
self.cost_center = "Main - _TC"
self.income_account = "Sales - _TC"
self.cash = "Cash - _TC"
self.create_child_cost_center() self.create_child_cost_center()
def create_child_cost_center(self): def create_child_cost_center(self):

6
erpnext/accounts/report/supplier_ledger_summary/test_supplier_ledger_summary.py
View File

@@ -9,9 +9,9 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestSupplierLedgerSummary(ERPNextTestSuite, AccountsTestMixin): class TestSupplierLedgerSummary(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.create_supplier() self.supplier = "_Test Supplier"
self.create_item() self.item = "_Test Item"
self.clear_old_entries() self.clear_old_entries()
def create_purchase_invoice(self, do_not_submit=False): def create_purchase_invoice(self, do_not_submit=False):

2
erpnext/accounts/report/tax_withholding_details/test_tax_withholding_details.py
View File

@@ -20,7 +20,7 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestTaxWithholdingDetails(ERPNextTestSuite, AccountsTestMixin): class TestTaxWithholdingDetails(ERPNextTestSuite, AccountsTestMixin):
def setUp(self): def setUp(self):
self.create_company() self.company = "_Test Company"
self.clear_old_entries() self.clear_old_entries()
create_records() create_records()