From 3d039d0fac0830bc630a2f998dc44a3baa576907 Mon Sep 17 00:00:00 2001 From: Deepesh Garg Date: Thu, 12 Aug 2021 18:18:03 +0530 Subject: [PATCH] fix: Store records to delete in a separate list --- erpnext/regional/india/utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/erpnext/regional/india/utils.py b/erpnext/regional/india/utils.py index 62c0187268b..746e5bf5911 100644 --- a/erpnext/regional/india/utils.py +++ b/erpnext/regional/india/utils.py @@ -856,10 +856,14 @@ def delete_gst_settings_for_company(doc, method): return gst_settings = frappe.get_doc("GST Settings") + records_to_delete = [] for d in reversed(gst_settings.get('gst_accounts')): if d.company == doc.name: - gst_settings.remove(d) + records_to_delete.append(d) + + for d in records_to_delete: + gst_settings.remove(d) gst_settings.save()