From 39b6f37a48aae0cc7891f1781f9bbb23e3fe1339 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Sun, 2 Aug 2026 22:06:21 +0530 Subject: [PATCH] ci(patch): use GITHUB_REF instead of rebuilding it from type and name GITHUB_REF is already the fully qualified ref for both branch and tag events, so reconstructing refs/heads/$GITHUB_REF_NAME and refs/tags/$GITHUB_REF_NAME just risks the two drifting apart. Keep the type check, since it still decides whether the develop fallback applies, and take the ref verbatim. --- .github/workflows/patch.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/patch.yml b/.github/workflows/patch.yml index f6c74bb5cc9..e8eaa4f8ae4 100644 --- a/.github/workflows/patch.yml +++ b/.github/workflows/patch.yml @@ -176,10 +176,10 @@ jobs: frappe_ref="refs/heads/$GITHUB_BASE_REF" fallback_to_develop=1 elif [ "${GITHUB_REF_TYPE:-}" = "branch" ]; then - frappe_ref="refs/heads/$GITHUB_REF_NAME" + frappe_ref="$GITHUB_REF" fallback_to_develop=1 elif [ "${GITHUB_REF_TYPE:-}" = "tag" ]; then - frappe_ref="refs/tags/$GITHUB_REF_NAME" + frappe_ref="$GITHUB_REF" else echo "Unsupported GitHub ref type: '${GITHUB_REF_TYPE:-unset}'" exit 1