nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 08:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Gratuity status not updated on salary slip submission

Browse Source
This commit is contained in:
Rucha Mahabal
2022-05-27 12:57:07 +05:30
parent e3c0d0134e
commit 385e22a067
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/payroll/doctype/salary_slip/salary_slip.py
View File

@@ -116,10 +116,10 @@ class SalarySlip(TransactionBase):
self.update_payment_status_for_gratuity() self.update_payment_status_for_gratuity()
def update_payment_status_for_gratuity(self): def update_payment_status_for_gratuity(self):
add_salary = frappe.db.get_all( additional_salary = frappe.db.get_all(
"Additional Salary", "Additional Salary",
filters={ filters={
"payroll_date": ("BETWEEN", [self.start_date, self.end_date]), "payroll_date": ("between", [self.start_date, self.end_date]),
"employee": self.employee, "employee": self.employee,
"ref_doctype": "Gratuity", "ref_doctype": "Gratuity",
"docstatus": 1, "docstatus": 1,
@@ -128,10 +128,10 @@ class SalarySlip(TransactionBase):
limit=1, limit=1,
) )
if len(add_salary): if additional_salary:
status = "Paid" if self.docstatus == 1 else "Unpaid" status = "Paid" if self.docstatus == 1 else "Unpaid"
if add_salary[0].name in [data.additional_salary for data in self.earnings]: if additional_salary[0].name in [entry.additional_salary for entry in self.earnings]:
frappe.db.set_value("Gratuity", add_salary.ref_docname, "status", status) frappe.db.set_value("Gratuity", additional_salary[0].ref_docname, "status", status)
def on_cancel(self): def on_cancel(self):
self.set_status() self.set_status()