nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-24 15:39:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2952 from neilLasrado/sales-person

Browse Source 
validation added to check if multiple sales person have been given the s...
This commit is contained in:
Nabin Hait
2015-03-12 17:52:40 +05:30
parent 1ca0b74e03 c6dfb02e4a
commit 382d21fa3c
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/setup/doctype/sales_person/sales_person.py
View File

@@ -14,6 +14,7 @@ class SalesPerson(NestedSet):
for d in self.get('targets') or []: for d in self.get('targets') or []:
if not flt(d.target_qty) and not flt(d.target_amount): if not flt(d.target_qty) and not flt(d.target_amount):
frappe.throw(_("Either target qty or target amount is mandatory.")) frappe.throw(_("Either target qty or target amount is mandatory."))
self.validate_employee_id()
def on_update(self): def on_update(self):
super(SalesPerson, self).on_update() super(SalesPerson, self).on_update()
@@ -26,3 +27,7 @@ class SalesPerson(NestedSet):
frappe.throw(_("User ID not set for Employee {0}").format(self.employee)) frappe.throw(_("User ID not set for Employee {0}").format(self.employee))
else: else:
return frappe.db.get_value("User", user, "email") or user return frappe.db.get_value("User", user, "email") or user
def validate_employee_id(self):
if frappe.db.exists({"doctype": "Sales Person","employee": self.employee}):
frappe.throw("Another sales person with the same employee id exists.")