nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-22 14:39:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: rewrite Total Stock Summary Report queries in QB

Browse Source 
(cherry picked from commit 7c759b193c)
This commit is contained in:
Sagar Sharma
2022-10-07 09:59:28 +05:30
committed by Mergify
parent 8af90b2421
commit 362bf5fc19
1 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
erpnext/stock/report/total_stock_summary/total_stock_summary.py
View File

@@ -4,60 +4,58 @@
import frappe import frappe
from frappe import _ from frappe import _
from frappe.query_builder.functions import Sum
def execute(filters=None): def execute(filters=None):
if not filters: if not filters:
filters = {} filters = {}
columns = get_columns() columns = get_columns(filters)
stock = get_total_stock(filters) stock = get_total_stock(filters)
return columns, stock return columns, stock
def get_columns(): def get_columns(filters):
columns = [ columns = [
_("Company") + ":Link/Company:250",
_("Warehouse") + ":Link/Warehouse:150",
_("Item") + ":Link/Item:150", _("Item") + ":Link/Item:150",
_("Description") + "::300", _("Description") + "::300",
_("Current Qty") + ":Float:100", _("Current Qty") + ":Float:100",
] ]
if filters.get("group_by") == "Warehouse":
columns.insert(0, _("Warehouse") + ":Link/Warehouse:150")
else:
columns.insert(0, _("Company") + ":Link/Company:250")
return columns return columns
def get_total_stock(filters): def get_total_stock(filters):
conditions = "" bin = frappe.qb.DocType("Bin")
columns = "" item = frappe.qb.DocType("Item")
wh = frappe.qb.DocType("Warehouse")
query = (
frappe.qb.from_(bin)
.inner_join(item)
.on(bin.item_code == item.item_code)
.inner_join(wh)
.on(wh.name == bin.warehouse)
.where(bin.actual_qty != 0)
)
if filters.get("group_by") == "Warehouse": if filters.get("group_by") == "Warehouse":
if filters.get("company"): if filters.get("company"):
conditions += " AND warehouse.company = %s" % frappe.db.escape( query = query.where(wh.company == filters.get("company"))
filters.get("company"), percent=False
)
conditions += " GROUP BY ledger.warehouse, item.item_code" query = query.select(bin.warehouse).groupby(bin.warehouse)
columns += "'' as company, ledger.warehouse"
else: else:
conditions += " GROUP BY warehouse.company, item.item_code" query = query.select(wh.company).groupby(wh.company)
columns += " warehouse.company, '' as warehouse"
return frappe.db.sql( query = query.select(
""" item.item_code, item.description, Sum(bin.actual_qty).as_("actual_qty")
SELECT ).groupby(item.item_code)
%s,
item.item_code, return query.run()
item.description,
sum(ledger.actual_qty) as actual_qty
FROM
`tabBin` AS ledger
INNER JOIN `tabItem` AS item
ON ledger.item_code = item.item_code
INNER JOIN `tabWarehouse` warehouse
ON warehouse.name = ledger.warehouse
WHERE
ledger.actual_qty != 0 %s"""
% (columns, conditions)
)