nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-13 06:31:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add raw material to its operation even when another operation uses the item

Browse Source 
get_item_details returns the whole Item document, so the dialog row's
name became the item code. get_item_data then matched that item code
against every Components row regardless of operation, so adding an item
already used by another operation silently updated that row's qty
instead of appending one for the target operation — which stayed empty
and failed 'please add raw materials or set a BOM' on submit.

Match the existing row by item code within the same operation: same
operation updates the qty, any other match appends a new row.

(cherry picked from commit 24f1f3dea8)

# Conflicts:
#	erpnext/manufacturing/doctype/bom/bom.py
This commit is contained in:
Mihir Kandoi
2026-08-08 15:27:39 +05:30
committed by Mergify
parent 0de97159ea
commit 35f9bec988
1 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
erpnext/manufacturing/doctype/bom/bom.py
View File

@@ -870,6 +870,27 @@ class BOM(WebsiteGenerator):
self.save()
<<<<<<< HEAD
=======
def _add_raw_material_row(self, operation_row_id, row):
row = parse_json(row)
row.update(get_item_details(row.get("item_code")))
row.operation_row_id = operation_row_id
item_row = self.get_item_data(row.item_code, operation_row_id)
if item_row:
item_row.qty = row.get("qty")
else:
row.idx = None
row.name = None
row.do_not_explode = 1
row.is_sub_assembly_item = self.is_sub_assembly_item(row.item_code)
self.append("items", row)
>>>>>>> 24f1f3dea8 (fix: add raw material to its operation even when another operation uses the item)
def is_sub_assembly_item(self, item_code):
if not self.operations:
return False
@@ -880,9 +901,9 @@ class BOM(WebsiteGenerator):
return False
def get_item_data(self, name):
def get_item_data(self, item_code, operation_row_id):
for row in self.items:
if row.item_code == name:
if row.item_code == item_code and cint(row.operation_row_id) == cint(operation_row_id):
return row
@frappe.whitelist()