nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 16:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #52752 from frappe/mergify/bp/version-16-hotfix/pr-52743

Browse Source 
bug: fix comparison regarding `None` values (backport #52743)
This commit is contained in:
Mihir Kandoi
2026-02-17 21:39:33 +05:30
committed by GitHub
parent 10be8f19e2 66d1b7c837
commit 35e9ca64ce
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/quality_inspection/quality_inspection.py
View File

@@ -278,7 +278,9 @@ class QualityInspection(Document):
def set_status_based_on_acceptance_values(self, reading): def set_status_based_on_acceptance_values(self, reading):
if not cint(reading.numeric): if not cint(reading.numeric):
result = reading.get("reading_value") == reading.get("value") reading_value = reading.get("reading_value") or ""
value = reading.get("value") or ""
result = reading_value == value
else: else:
# numeric readings # numeric readings
result = self.min_max_criteria_passed(reading) result = self.min_max_criteria_passed(reading)