nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-23 15:09:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #48968 from khushi8112/validate-asset-before-submitting-depreciation-schedule

Browse Source 
fix: validate asset before submitting depreciation schedule
This commit is contained in:
Khushi Rawat
2025-08-05 15:01:41 +05:30
committed by GitHub
parent 3bda9c54ae d6fb99916e
commit 338ee746ec
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
erpnext/assets/doctype/asset_depreciation_schedule/asset_depreciation_schedule.py
View File

@@ -86,8 +86,24 @@ class AssetDepreciationSchedule(DepreciationScheduleController):
) )
def on_submit(self): def on_submit(self):
self.validate_asset()
self.db_set("status", "Active") self.db_set("status", "Active")
def validate_asset(self):
asset = frappe.get_doc("Asset", self.asset)
if not asset.calculate_depreciation:
frappe.throw(
_("Asset {0} is not set to calculate depreciation.").format(
get_link_to_form("Asset", self.asset)
)
)
if asset.docstatus != 1:
frappe.throw(
_("Asset {0} is not submitted. Please submit the asset before proceeding.").format(
get_link_to_form("Asset", self.asset)
)
)
def on_cancel(self): def on_cancel(self):
self.db_set("status", "Cancelled") self.db_set("status", "Cancelled")
if not self.flags.should_not_cancel_depreciation_entries: if not self.flags.should_not_cancel_depreciation_entries:
@@ -96,6 +112,13 @@ class AssetDepreciationSchedule(DepreciationScheduleController):
def cancel_depreciation_entries(self): def cancel_depreciation_entries(self):
for d in self.get("depreciation_schedule"): for d in self.get("depreciation_schedule"):
if d.journal_entry: if d.journal_entry:
je_status = frappe.db.get_value("Journal Entry", d.journal_entry, "docstatus")
if je_status == 0:
frappe.throw(
_(
"Cannot cancel Asset Depreciation Schedule {0} as it has a draft journal entry {1}."
).format(self.name, d.journal_entry)
)
frappe.get_doc("Journal Entry", d.journal_entry).cancel() frappe.get_doc("Journal Entry", d.journal_entry).cancel()
def update_shift_depr_schedule(self): def update_shift_depr_schedule(self):