diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
index 31d21bc1fe6..120d27d2cd4 100644
--- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
+++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py
@@ -2857,10 +2857,10 @@ def save_company_master_details(name, company, details):
validate_email_address(details.email, throw=True)
company_fields = ["company_logo", "website", "phone_no", "email"]
- updated_fields = {field: details.get(field) for field in company_fields if details.get(field)}
+ company_fields_to_update = {field: details.get(field) for field in company_fields if details.get(field)}
- if updated_fields:
- frappe.db.set_value("Company", company, updated_fields)
+ if company_fields_to_update:
+ frappe.db.set_value("Company", company, company_fields_to_update)
company_address = details.get("company_address")
if details.get("address_line1"):
@@ -2883,8 +2883,8 @@ def save_company_master_details(name, company, details):
company_address = address_doc.name
if company_address:
- current_display = frappe.db.get_value("Sales Invoice", name, "company_address_display")
- if not current_display or details.get("address_line1"):
+ company_address_display = frappe.db.get_value("Sales Invoice", name, "company_address_display")
+ if not company_address_display or details.get("address_line1"):
frappe.db.set_value(
"Sales Invoice",
name,
diff --git a/erpnext/accounts/letterhead/letterhead_plain.html b/erpnext/accounts/letterhead/letterhead_plain.html
index 46613a31308..8fbf58ec68f 100644
--- a/erpnext/accounts/letterhead/letterhead_plain.html
+++ b/erpnext/accounts/letterhead/letterhead_plain.html
@@ -69,17 +69,19 @@
{{ doc.company }}
{% if doc.company_address %}
- {% set company_address_display = frappe.get_doc("Address", doc.company_address) %}
- {{ company_address_display.address_line1 or "" }}
- {% if company_address_display.address_line2 %}{{ company_address_display.address_line2 }}
{% endif %}
- {{ company_address_display.city or "" }}, {{ company_address_display.state or "" }} {{ company_address_display.pincode or "" }}, {{ company_address_display.country or "" }}
+ {% set company_address = frappe.db.get_value("Address", doc.company_address, ["address_line1", "address_line2", "city", "state", "pincode", "country"], as_dict=True) %}
+
+ {{ company_address.get("address_line1") or "" }}
+ {% if company_address.get("address_line2") %}{{ company_address.get("address_line2") }}
{% endif %}
+ {{ company_address.get("city") or "" }}, {{ company_address.get("state") or "" }} {{ company_address.get("pincode") or "" }}, {{ company_address.get("country") or "" }}
{% endif %}