From 32e44f5121952a6d54901c18ec6c1f7bbb8f80de Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 27 Mar 2022 20:26:55 +0530 Subject: [PATCH] fix: correctly capture first serial no --- erpnext/public/js/utils/barcode_scanner.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/erpnext/public/js/utils/barcode_scanner.js b/erpnext/public/js/utils/barcode_scanner.js index dabc3d11c0b..95ed0268507 100644 --- a/erpnext/public/js/utils/barcode_scanner.js +++ b/erpnext/public/js/utils/barcode_scanner.js @@ -93,8 +93,15 @@ erpnext.utils.BarcodeScanner = class BarcodeScanner { set_serial_no(row, serial_no) { if (serial_no && frappe.meta.has_field(row.doctype, this.serial_no_field)) { - const value = row[this.serial_no_field] + '\n' + serial_no; - frappe.model.set_value(row.doctype, row.name, this.serial_no_field, value); + const existing_serial_nos = row[this.serial_no_field]; + let new_serial_nos = ''; + + if (!!existing_serial_nos) { + new_serial_nos = existing_serial_nos + '\n' + serial_no; + } else { + new_serial_nos = serial_no; + } + frappe.model.set_value(row.doctype, row.name, this.serial_no_field, new_serial_nos); } }