nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-17 10:36:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: clear stale payment rows on non-POS returns so they don't surface in bank reconciliation (#55903)

Browse Source
This commit is contained in:
Jatin3128
2026-06-16 10:42:36 +05:30
committed by GitHub
parent 01a10fb5b0
commit 322d4dff25
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -412,8 +412,8 @@ class SalesInvoice(SellingController):
validate_account_head(item.idx, item.income_account, self.company, _("Income")) validate_account_head(item.idx, item.income_account, self.company, _("Income"))
def before_save(self): def before_save(self):
POSService(self).update_paid_amount()
POSService(self).set_account_for_mode_of_payment() POSService(self).set_account_for_mode_of_payment()
POSService(self).set_paid_amount()
def before_submit(self): def before_submit(self):
self.add_remarks() self.add_remarks()

9
erpnext/accounts/doctype/sales_invoice/services/pos.py
View File

@@ -114,10 +114,17 @@ class POSService:
return pos return pos
def set_paid_amount(self) -> None: def update_paid_amount(self) -> None:
doc = self.doc doc = self.doc
paid_amount = 0.0 paid_amount = 0.0
base_paid_amount = 0.0 base_paid_amount = 0.0
if not cint(doc.is_pos) and doc.is_return:
doc.set("payments", [])
doc.paid_amount = paid_amount
doc.base_paid_amount = base_paid_amount
return
for data in doc.payments: for data in doc.payments:
data.base_amount = flt(data.amount * doc.conversion_rate, doc.precision("base_paid_amount")) data.base_amount = flt(data.amount * doc.conversion_rate, doc.precision("base_paid_amount"))
paid_amount += data.amount paid_amount += data.amount