nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 15:38:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(manufacturing): align quantity split rounding

Browse Source
This commit is contained in:
Mihir Kandoi
2026-08-09 21:43:00 +05:30
parent beed05ac18
commit 317dd18ce5
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/manufacturing/doctype/job_card/job_card.py
View File

@@ -1567,7 +1567,11 @@ class JobCard(Document):
return return
precision = self.precision("total_completed_qty") precision = self.precision("total_completed_qty")
accounted_qty = flt(kwargs.qty) + flt(kwargs.pending_qty) + flt(kwargs.process_loss_qty) accounted_qty = flt(
flt(kwargs.qty, precision)
+ flt(kwargs.pending_qty, precision)
+ flt(kwargs.process_loss_qty, precision)
)
if flt(accounted_qty, precision) == flt(kwargs.for_quantity, precision): if flt(accounted_qty, precision) == flt(kwargs.for_quantity, precision):
return return

6
erpnext/manufacturing/doctype/job_card/test_job_card.py
View File

@@ -1831,6 +1831,12 @@ class TestJobCard(ERPNextTestSuite):
frappe._dict(for_quantity=3, qty=3, pending_qty=2, process_loss_qty=0), frappe._dict(for_quantity=3, qty=3, pending_qty=2, process_loss_qty=0),
) )
self.assertRaises(
frappe.ValidationError,
jc.validate_completion_qty_split,
frappe._dict(for_quantity=1, qty=0.3334, pending_qty=0.3334, process_loss_qty=0.3334),
)
def create_bom_with_multiple_operations(): def create_bom_with_multiple_operations():
"Create a BOM with multiple operations and Material Transfer against Job Card" "Create a BOM with multiple operations and Material Transfer against Job Card"