From 30ba93fb8f299e0ee51ebf527393c72a64f82063 Mon Sep 17 00:00:00 2001 From: Loic Oberle Date: Fri, 22 May 2026 12:40:40 +0200 Subject: [PATCH] refactor(supplier_quotation): Replace SQL by the orm (#55155) --- .../supplier_quotation/supplier_quotation.py | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py index b47941e945a..c7fa6ecfc63 100644 --- a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py +++ b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.py @@ -347,14 +347,12 @@ def make_quotation(source_name: str, target_doc: str | Document | None = None): def set_expired_status(): - frappe.db.sql( - """ - UPDATE - `tabSupplier Quotation` SET `status` = 'Expired' - WHERE - `status` not in ('Cancelled', 'Stopped') AND `valid_till` < %s - """, - (nowdate()), + frappe.db.set_value( + "Supplier Quotation", + filters={"status": ["not in", ["Cancelled", "Stopped"]], "valid_till": ["<", nowdate()]}, + fieldname="status", + value="Expired", + update_modified=True, )