refactor: Better organizing of the fields in various doctypes

This commit is contained in:
Deepesh Garg
2026-02-04 11:18:09 +05:30
parent c7fd855092
commit 2f2e16fc33
7 changed files with 109 additions and 122 deletions

View File

@@ -12,10 +12,11 @@
"field_order": [
"naming_series",
"supplier_name",
"country",
"supplier_type",
"gender",
"column_break0",
"supplier_group",
"supplier_type",
"country",
"is_transporter",
"image",
"defaults_section",
@@ -62,8 +63,8 @@
"allow_purchase_invoice_creation_without_purchase_order",
"allow_purchase_invoice_creation_without_purchase_receipt",
"column_break_54",
"is_frozen",
"disabled",
"is_frozen",
"warn_rfqs",
"warn_pos",
"prevent_rfqs",
@@ -74,8 +75,7 @@
"column_break_59",
"release_date",
"portal_users_tab",
"portal_users",
"column_break_1mqv"
"portal_users"
],
"fields": [
{
@@ -468,10 +468,6 @@
"label": "Supplier Portal Users",
"options": "Portal User"
},
{
"fieldname": "column_break_1mqv",
"fieldtype": "Column Break"
},
{
"fieldname": "column_break_mglr",
"fieldtype": "Column Break"
@@ -487,6 +483,13 @@
"fieldtype": "Link",
"label": "Tax Withholding Group",
"options": "Tax Withholding Group"
},
{
"depends_on": "eval:doc.supplier_type == 'Individual'",
"fieldname": "gender",
"fieldtype": "Link",
"label": "Gender",
"options": "Gender"
}
],
"grid_page_length": 50,
@@ -500,7 +503,7 @@
"link_fieldname": "party"
}
],
"modified": "2026-01-16 15:56:31.139206",
"modified": "2026-02-02 12:36:51.566439",
"modified_by": "Administrator",
"module": "Buying",
"name": "Supplier",

View File

@@ -27,16 +27,11 @@ class Supplier(TransactionBase):
from typing import TYPE_CHECKING
if TYPE_CHECKING:
from frappe.types import DF
from erpnext.accounts.doctype.allowed_to_transact_with.allowed_to_transact_with import (
AllowedToTransactWith,
)
from erpnext.accounts.doctype.allowed_to_transact_with.allowed_to_transact_with import AllowedToTransactWith
from erpnext.accounts.doctype.party_account.party_account import PartyAccount
from erpnext.buying.doctype.customer_number_at_supplier.customer_number_at_supplier import (
CustomerNumberAtSupplier,
)
from erpnext.buying.doctype.customer_number_at_supplier.customer_number_at_supplier import CustomerNumberAtSupplier
from erpnext.utilities.doctype.portal_user.portal_user import PortalUser
from frappe.types import DF
accounts: DF.Table[PartyAccount]
allow_purchase_invoice_creation_without_purchase_order: DF.Check
@@ -49,6 +44,7 @@ class Supplier(TransactionBase):
default_price_list: DF.Link | None
disabled: DF.Check
email_id: DF.ReadOnly | None
gender: DF.Link | None
hold_type: DF.Literal["", "All", "Invoices", "Payments"]
image: DF.AttachImage | None
is_frozen: DF.Check