From 2ea63ce70920aa0348f26286fc5e52b7f507bcda Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Thu, 23 Jul 2026 16:45:57 +0530 Subject: [PATCH] refactor: drop translation marking from default warehouse names warehouse_name is a Data field shown as stored, and everywhere else users see the docname, which carries the company abbr ("Stores - F") and is never translated - a translated bare "Stores" has no display use, so the identity _ marking from #57392 serves nothing. The exists-guard keeps the runtime session-translation match that protects legacy sites from duplicate English warehouses. --- erpnext/setup/doctype/company/company.py | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/erpnext/setup/doctype/company/company.py b/erpnext/setup/doctype/company/company.py index 57cc0783002..f5e31839e5a 100644 --- a/erpnext/setup/doctype/company/company.py +++ b/erpnext/setup/doctype/company/company.py @@ -448,23 +448,18 @@ class Company(NestedSet): frappe.clear_cache() def create_default_warehouses(self): - from erpnext.setup.utils import identity as _ - parent_warehouse = None for wh_detail in [ - {"warehouse_name": _("All Warehouses"), "is_group": 1}, - {"warehouse_name": _("Stores"), "is_group": 0}, - {"warehouse_name": _("Work In Progress"), "is_group": 0}, - {"warehouse_name": _("Finished Goods"), "is_group": 0}, - {"warehouse_name": _("Goods In Transit"), "is_group": 0, "warehouse_type": "Transit"}, + {"warehouse_name": "All Warehouses", "is_group": 1}, + {"warehouse_name": "Stores", "is_group": 0}, + {"warehouse_name": "Work In Progress", "is_group": 0}, + {"warehouse_name": "Finished Goods", "is_group": 0}, + {"warehouse_name": "Goods In Transit", "is_group": 0, "warehouse_type": "Transit"}, ]: if frappe.db.exists( "Warehouse", { - "warehouse_name": ( - "in", - (wh_detail["warehouse_name"], frappe._(wh_detail["warehouse_name"])), - ), + "warehouse_name": ("in", (wh_detail["warehouse_name"], _(wh_detail["warehouse_name"]))), "company": self.name, }, ):