nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-20 13:39:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(supplier): use frappe orm for database queries (#54842)

Browse Source 
replace raw SQL with frappe orm to leverage the framework's native
capabilities. this improves code maintainability and adheres to frappe
best practices.
This commit is contained in:
Loïc Oberle
2026-05-11 17:54:28 +02:00
committed by GitHub
parent 0729c9a9cd
commit 2e958de95b
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py
View File

@@ -181,20 +181,15 @@ def daterange(start_date, end_date):
def refresh_scorecards(): def refresh_scorecards():
scorecards = frappe.db.sql( """
""" Refresh the scorecards
SELECT """
sc.name scorecards = frappe.get_list("Supplier Scorecard", fields=["name"], pluck="name", limit_page_length=0)
FROM for sc_name in scorecards:
`tabSupplier Scorecard` sc""",
{},
as_dict=1,
)
for sc in scorecards:
# Check to see if any new scorecard periods are created # Check to see if any new scorecard periods are created
if make_all_scorecards(sc.name) > 0: if make_all_scorecards(sc_name) > 0:
# Save the scorecard to update the score and standings # Save the scorecard to update the score and standings
frappe.get_doc("Supplier Scorecard", sc.name).save() frappe.get_doc("Supplier Scorecard", sc_name).save()
@frappe.whitelist() @frappe.whitelist()