nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-16 18:24:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: parse native JSON request args in erpnext_integrations/doctype/plaid_settings/plaid_settings.py

Browse Source 
Use frappe.parse_json instead of json.loads so the whitelisted endpoints
accept native JSON types (list/dict/bool) in addition to JSON strings.
This commit is contained in:
Mihir Kandoi
2026-06-24 20:37:32 +05:30
parent afb2616aee
commit 2e75a4b830
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.py
View File

@@ -51,8 +51,8 @@ def get_plaid_configuration():
@frappe.whitelist() @frappe.whitelist()
def add_institution(token: str, response: str): def add_institution(token: str, response: str | dict):
response = json.loads(response) response = frappe.parse_json(response)
plaid = PlaidConnector() plaid = PlaidConnector()
access_token = plaid.get_access_token(token) access_token = plaid.get_access_token(token)
@@ -81,12 +81,11 @@ def add_institution(token: str, response: str):
@frappe.whitelist() @frappe.whitelist()
def add_bank_accounts(response: str | dict, bank: str | dict, company: str): def add_bank_accounts(response: str | dict, bank: str | dict, company: str):
try: try:
response = json.loads(response) response = frappe.parse_json(response)
except TypeError: except TypeError:
pass pass
if isinstance(bank, str): bank = frappe.parse_json(bank)
bank = json.loads(bank)
result = [] result = []
parent_gl_account = frappe.db.get_all( parent_gl_account = frappe.db.get_all(
@@ -358,8 +357,8 @@ def get_company(bank_account_name):
@frappe.whitelist() @frappe.whitelist()
def update_bank_account_ids(response: str): def update_bank_account_ids(response: str | dict):
data = json.loads(response) data = frappe.parse_json(response)
institution_name = data["institution"]["name"] institution_name = data["institution"]["name"]
bank = frappe.get_doc("Bank", institution_name).as_dict() bank = frappe.get_doc("Bank", institution_name).as_dict()
bank_account_name = f"{data['account']['name']} - {institution_name}" bank_account_name = f"{data['account']['name']} - {institution_name}"