Merge branch 'develop' into fix-depr-after-sale

This commit is contained in:
Saqib
2021-10-27 15:12:51 +05:30
committed by GitHub
28 changed files with 315 additions and 69 deletions

View File

@@ -614,11 +614,17 @@ def get_custom_fields():
fieldtype='Currency', insert_after='monthly_hra_exemption', read_only=1, depends_on='house_rent_payment_amount')
],
'Supplier': [
{
'fieldname': 'pan',
'label': 'PAN',
'fieldtype': 'Data',
'insert_after': 'supplier_type'
},
{
'fieldname': 'gst_transporter_id',
'label': 'GST Transporter ID',
'fieldtype': 'Data',
'insert_after': 'supplier_type',
'insert_after': 'pan',
'depends_on': 'eval:doc.is_transporter'
},
{
@@ -640,11 +646,17 @@ def get_custom_fields():
}
],
'Customer': [
{
'fieldname': 'pan',
'label': 'PAN',
'fieldtype': 'Data',
'insert_after': 'customer_type'
},
{
'fieldname': 'gst_category',
'label': 'GST Category',
'fieldtype': 'Select',
'insert_after': 'customer_type',
'insert_after': 'pan',
'options': 'Registered Regular\nRegistered Composition\nUnregistered\nSEZ\nOverseas\nConsumer\nDeemed Export\nUIN Holders',
'default': 'Unregistered'
},

View File

@@ -62,7 +62,7 @@ def validate_gstin_for_india(doc, method):
.format(doc.gst_state_number), title=_("Invalid GSTIN"))
def validate_pan_for_india(doc, method):
if doc.get('country') != 'India' or not doc.pan:
if doc.get('country') != 'India' or not doc.get('pan'):
return
if not PAN_NUMBER_FORMAT.match(doc.pan):