Merge pull request #44850 from ruthra-kumar/remove_hardcoded_names_in_test

refacto(test): remove hardcoded names
This commit is contained in:
ruthra kumar
2024-12-23 15:25:26 +05:30
committed by GitHub

View File

@@ -1992,6 +1992,7 @@ class TestAccountsController(IntegrationTestCase):
adv.save() adv.save()
self.assertEqual(adv.paid_from, self.advance_received_usd) self.assertEqual(adv.paid_from, self.advance_received_usd)
adv.submit() adv.submit()
adv.reload()
# create sales invoice with advance received # create sales invoice with advance received
si = self.create_sales_invoice(qty=1, conversion_rate=80, rate=1, do_not_submit=True) si = self.create_sales_invoice(qty=1, conversion_rate=80, rate=1, do_not_submit=True)
@@ -1999,8 +2000,8 @@ class TestAccountsController(IntegrationTestCase):
si.append( si.append(
"advances", "advances",
{ {
"reference_type": "Payment Entry", "reference_type": adv.doctype,
"reference_name": "ACC-PAY-2024-00001", "reference_name": adv.name,
"remarks": "Amount INR 1 received from _Test MC Customer USD\nTransaction reference no Test001 dated 2024-12-19", "remarks": "Amount INR 1 received from _Test MC Customer USD\nTransaction reference no Test001 dated 2024-12-19",
"advance_amount": 1.0, "advance_amount": 1.0,
"allocated_amount": 1.0, "allocated_amount": 1.0,
@@ -2050,8 +2051,8 @@ class TestAccountsController(IntegrationTestCase):
pi.append( pi.append(
"advances", "advances",
{ {
"reference_type": "Payment Entry", "reference_type": adv.doctype,
"reference_name": "ACC-PAY-2024-00002", "reference_name": adv.name,
"remarks": "Amount INR 1 paid to _Test MC Supplier USD\nTransaction reference no Test001 dated 2024-12-20", "remarks": "Amount INR 1 paid to _Test MC Supplier USD\nTransaction reference no Test001 dated 2024-12-20",
"advance_amount": 1.0, "advance_amount": 1.0,
"allocated_amount": 1.0, "allocated_amount": 1.0,