From 2d2b45f2705247776eff2f79a2cae647f38fa752 Mon Sep 17 00:00:00 2001 From: Loic Oberle Date: Sat, 23 May 2026 08:10:04 +0200 Subject: [PATCH] refactor(sales_order): Replace SQL with ORM in check_modified_date (#55205) --- erpnext/selling/doctype/sales_order/sales_order.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index 50dd739b074..05e2e66d1a8 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -593,8 +593,7 @@ class SalesOrder(SellingController): def check_modified_date(self): mod_db = frappe.db.get_value("Sales Order", self.name, "modified") - date_diff = frappe.db.sql(f"select TIMEDIFF('{mod_db}', '{cstr(self.modified)}')") - if date_diff and date_diff[0][0]: + if mod_db and cstr(mod_db) != cstr(self.modified): frappe.throw(_("{0} {1} has been modified. Please refresh.").format(self.doctype, self.name)) def update_status(self, status):