From 2c1f72e44cac422f5f2ab94b7b2934a5b0979c83 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Mon, 19 Aug 2024 08:16:11 +0530 Subject: [PATCH] fix: ensure `SellingController.onload` gets called for SO & DN (cherry picked from commit 8431e3c275cc8cad8406f8a27436ecf31140106d) --- erpnext/selling/doctype/sales_order/sales_order.py | 2 ++ erpnext/stock/doctype/delivery_note/delivery_note.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index 570677aad78..2f2d840cce8 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -185,6 +185,8 @@ class SalesOrder(SellingController): super().__init__(*args, **kwargs) def onload(self) -> None: + super().onload() + if frappe.db.get_single_value("Stock Settings", "enable_stock_reservation"): if self.has_unreserved_stock(): self.set_onload("has_unreserved_stock", True) diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.py b/erpnext/stock/doctype/delivery_note/delivery_note.py index 8a096aca80c..847a57baa72 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/delivery_note.py @@ -208,6 +208,8 @@ class DeliveryNote(SellingController): ) def onload(self): + super().onload() + if self.docstatus == 0: self.set_onload("has_unpacked_items", self.has_unpacked_items())