From 2a788a4fb162ca582a043811dd94d197ae871d39 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 13 Mar 2025 14:30:38 +0530 Subject: [PATCH] refactor: print receipt on order complete on pos (backport #46501) (#46507) * refactor: print receipt on order complete on pos (#46501) (cherry picked from commit 0552209310c7f3b17d02508a12b7547068a906cc) # Conflicts: # erpnext/selling/page/point_of_sale/pos_past_order_summary.js * chore: resolve conflict --------- Co-authored-by: Diptanil Saha --- .../page/point_of_sale/pos_controller.js | 2 +- .../point_of_sale/pos_past_order_summary.js | 20 ++++--------------- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/erpnext/selling/page/point_of_sale/pos_controller.js b/erpnext/selling/page/point_of_sale/pos_controller.js index e7208c41dde..b7062abecba 100644 --- a/erpnext/selling/page/point_of_sale/pos_controller.js +++ b/erpnext/selling/page/point_of_sale/pos_controller.js @@ -449,6 +449,7 @@ erpnext.PointOfSale.Controller = class { init_order_summary() { this.order_summary = new erpnext.PointOfSale.PastOrderSummary({ wrapper: this.$components_wrapper, + settings: this.settings, events: { get_frm: () => this.frm, @@ -485,7 +486,6 @@ erpnext.PointOfSale.Controller = class { ]); }, }, - pos_profile: this.pos_profile, }); } diff --git a/erpnext/selling/page/point_of_sale/pos_past_order_summary.js b/erpnext/selling/page/point_of_sale/pos_past_order_summary.js index d4b5562c218..cf775176c07 100644 --- a/erpnext/selling/page/point_of_sale/pos_past_order_summary.js +++ b/erpnext/selling/page/point_of_sale/pos_past_order_summary.js @@ -1,8 +1,8 @@ erpnext.PointOfSale.PastOrderSummary = class { - constructor({ wrapper, events, pos_profile }) { + constructor({ wrapper, settings, events }) { this.wrapper = wrapper; this.events = events; - this.pos_profile = pos_profile; + this.print_receipt_on_order_complete = settings.print_receipt_on_order_complete; this.init_component(); } @@ -357,8 +357,8 @@ erpnext.PointOfSale.PastOrderSummary = class { this.add_summary_btns(condition_btns_map); - if (after_submission) { - this.print_receipt_on_order_complete(); + if (after_submission && this.print_receipt_on_order_complete) { + this.print_receipt(); } } @@ -426,16 +426,4 @@ erpnext.PointOfSale.PastOrderSummary = class { toggle_component(show) { show ? this.$component.css("display", "flex") : this.$component.css("display", "none"); } - - async print_receipt_on_order_complete() { - const res = await frappe.db.get_value( - "POS Profile", - this.pos_profile, - "print_receipt_on_order_complete" - ); - - if (res.message.print_receipt_on_order_complete) { - this.print_receipt(); - } - } };