nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 17:04:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove frappe.flags from accounting dimensions filter

Browse Source
This commit is contained in:
ruthra kumar
2026-02-27 16:37:27 +05:30
parent 048608556c
commit 290f979fd3
1 changed files with 27 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.py
View File

@@ -69,37 +69,34 @@ class AccountingDimensionFilter(Document):
def get_dimension_filter_map(): def get_dimension_filter_map():
if not frappe.flags.get("dimension_filter_map"): filters = frappe.db.sql(
filters = frappe.db.sql( """
""" SELECT
SELECT a.applicable_on_account, d.dimension_value, p.accounting_dimension,
a.applicable_on_account, d.dimension_value, p.accounting_dimension, p.allow_or_restrict, p.fieldname, a.is_mandatory
p.allow_or_restrict, p.fieldname, a.is_mandatory FROM
FROM `tabApplicable On Account` a,
`tabApplicable On Account` a, `tabAccounting Dimension Filter` p
`tabAccounting Dimension Filter` p LEFT JOIN `tabAllowed Dimension` d ON d.parent = p.name
LEFT JOIN `tabAllowed Dimension` d ON d.parent = p.name WHERE
WHERE p.name = a.parent
p.name = a.parent AND p.disabled = 0
AND p.disabled = 0 """,
""", as_dict=1,
as_dict=1, )
dimension_filter_map = {}
for f in filters:
build_map(
dimension_filter_map,
f.fieldname,
f.applicable_on_account,
f.dimension_value,
f.allow_or_restrict,
f.is_mandatory,
) )
return dimension_filter_map
dimension_filter_map = {}
for f in filters:
build_map(
dimension_filter_map,
f.fieldname,
f.applicable_on_account,
f.dimension_value,
f.allow_or_restrict,
f.is_mandatory,
)
frappe.flags.dimension_filter_map = dimension_filter_map
return frappe.flags.dimension_filter_map
def build_map(map_object, dimension, account, filter_value, allow_or_restrict, is_mandatory): def build_map(map_object, dimension, account, filter_value, allow_or_restrict, is_mandatory):