nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-19 04:59:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #49836 from rohitwaghchaure/fixed-stock-reservation-on-cancel-wo

Browse Source 
fix: reverse delivered qty in stock resrvation on cancellation
This commit is contained in:
Mihir Kandoi
2025-10-01 21:03:57 +05:30
committed by GitHub
parent 9c1be96990 20e9706ec3
commit 282d28fbce
1 changed files with 3 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/stock/doctype/stock_reservation_entry/stock_reservation_entry.py
View File

@@ -120,29 +120,20 @@ class StockReservationEntry(Document):
).run(as_list=True)[0][0] or 0 ).run(as_list=True)[0][0] or 0
sres = self.get_from_voucher_reservation_entries() sres = self.get_from_voucher_reservation_entries()
index = 0
for row in sres: for row in sres:
if delivered_qty < 0.0:
break
status = "Reserved" status = "Reserved"
if self.has_batch_no or self.has_serial_no: if self.has_batch_no or self.has_serial_no:
serial_batch_data = self.get_serial_batch_entries() serial_batch_data = self.get_serial_batch_entries()
update_serial_batch_delivered_qty(serial_batch_data, row.name, is_cancelled=True) update_serial_batch_delivered_qty(serial_batch_data, row.name, is_cancelled=True)
if delivered_qty <= 0 or index == 0:
frappe.db.set_value(
"Stock Reservation Entry",
row.name,
{"delivered_qty": delivered_qty, "status": status},
)
continue
index += 1
if row.reserved_qty > delivered_qty: if row.reserved_qty > delivered_qty:
frappe.db.set_value( frappe.db.set_value(
"Stock Reservation Entry", "Stock Reservation Entry",
row.name, row.name,
"delivered_qty",
{"delivered_qty": delivered_qty, "status": status}, {"delivered_qty": delivered_qty, "status": status},
) )
@@ -151,7 +142,6 @@ class StockReservationEntry(Document):
frappe.db.set_value( frappe.db.set_value(
"Stock Reservation Entry", "Stock Reservation Entry",
row.name, row.name,
"delivered_qty",
{"delivered_qty": row.reserved_qty, "status": "Delivered"}, {"delivered_qty": row.reserved_qty, "status": "Delivered"},
) )