From 27c266b0815b377cbd48f97e67e768b24deeb47c Mon Sep 17 00:00:00 2001 From: Revant Nandgaonkar Date: Wed, 18 Nov 2015 13:28:09 +0530 Subject: [PATCH] improve mode_of_payment validate_accounts using frappe.db.get_value instead of frappe.get_list --- .../doctype/mode_of_payment/mode_of_payment.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py b/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py index 4a9ea9cda78..36d54b6e004 100644 --- a/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py +++ b/erpnext/accounts/doctype/mode_of_payment/mode_of_payment.py @@ -24,13 +24,5 @@ class ModeofPayment(Document): def validate_accounts(self): for entry in self.accounts: """Error when Company of Ledger account doesn't match with Company Selected""" - account = frappe.get_list("Account", - fields=["name"], - filters = { - "company": entry.company, - "name": entry.default_account - }) - try: - account[0].name - except IndexError: + if frappe.db.get_value("Account", entry.default_account, "company") != entry.company: frappe.throw(_("Account does not match with Company"))