nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-02 16:13:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move warehouse defaults from Stock Settings to Company

Browse Source 
Default Warehouse and Sample Retention Warehouse were global singles, so every
consumer had to re-check that the warehouse belonged to the transaction's
company before using it. Both now live on Company, under a new Warehouse
Defaults section that also collects the warehouse fields Company already had.

The company check moves to Company.validate_warehouses, which also rejects
group warehouses for all seven fields — a group or cross-company value there
already failed at SLE time, this just surfaces it at the source.

New companies get their Stores warehouse as Default Warehouse via
create_default_warehouses, replacing the setup-wizard and test-fixture code
that seeded the global.
This commit is contained in:
Mihir Kandoi
2026-07-28 19:29:18 +05:30
parent 2f07dfc474
commit 26613d258e
23 changed files with 177 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/controllers/selling_controller.py
View File

@@ -911,8 +911,8 @@ class SellingController(StockController):
if self.get("is_return"):
return
sample_retention_warehouse = frappe.db.get_single_value(
"Stock Settings", "sample_retention_warehouse"
sample_retention_warehouse = frappe.get_cached_value(
"Company", self.company, "sample_retention_warehouse"
)
if not sample_retention_warehouse:
return