From 251e7b623c430e460b65ba359a95680166fcca8f Mon Sep 17 00:00:00 2001 From: ljain112 Date: Wed, 27 May 2026 13:06:07 +0530 Subject: [PATCH] fix: changes as per review --- .../tax_withholding_category.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py index c29a7a88f17..f6ce7739acd 100644 --- a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py +++ b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py @@ -7,7 +7,7 @@ import frappe from frappe import _ from frappe.model.document import Document from frappe.query_builder.functions import Sum -from frappe.utils import getdate +from frappe.utils import cstr, getdate from erpnext import allow_regional from erpnext.controllers.accounts_controller import validate_account_head @@ -48,7 +48,7 @@ class TaxWithholdingCategory(Document): for d in self.get("rates"): if getdate(d.from_date) >= getdate(d.to_date): frappe.throw(_("Row #{0}: From Date cannot be before To Date").format(d.idx)) - group_rates[d.tax_withholding_group or ""].append(d) + group_rates[cstr(d.tax_withholding_group)].append(d) # Validate overlapping dates within each group for group, rates in group_rates.items(): @@ -92,9 +92,9 @@ class TaxWithholdingCategory(Document): def get_applicable_tax_row(self, posting_date, tax_withholding_group): for row in self.rates: - if getdate(row.from_date) <= getdate(posting_date) <= getdate(row.to_date) and ( - row.tax_withholding_group or "" - ) == (tax_withholding_group or ""): + if getdate(row.from_date) <= getdate(posting_date) <= getdate(row.to_date) and cstr( + row.tax_withholding_group + ) == cstr(tax_withholding_group): return row frappe.throw(_("No Tax Withholding data found for the current posting date.")) @@ -115,7 +115,7 @@ class TaxWithholdingDetails: def __init__( self, tax_withholding_categories: list[str], - tax_withholding_group: str, + tax_withholding_group: str | None, posting_date: str, party_type: str, party: str,