nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-29 18:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

a[fix] check content before making in condition

Browse Source
This commit is contained in:
Saurabh
2018-04-17 20:45:06 +05:30
parent 46ffbb74ff
commit 2476a8aab9
2 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
erpnext/stock/report/stock_balance/stock_balance.py
View File

@@ -200,13 +200,14 @@ def get_item_details(items, sle, filters):
item_details = {} item_details = {}
if not items: if not items:
items = list(set([d.item_code for d in sle])) items = list(set([d.item_code for d in sle]))
for item in frappe.db.sql(""" if items:
select name, item_name, description, item_group, brand, stock_uom for item in frappe.db.sql("""
from `tabItem` select name, item_name, description, item_group, brand, stock_uom
where name in ({0}) from `tabItem`
""".format(', '.join(['"' + frappe.db.escape(i, percent=False) + '"' for i in items])), as_dict=1): where name in ({0})
item_details.setdefault(item.name, item) """.format(', '.join(['"' + frappe.db.escape(i, percent=False) + '"' for i in items])), as_dict=1):
item_details.setdefault(item.name, item)
if filters.get('show_variant_attributes', 0) == 1: if filters.get('show_variant_attributes', 0) == 1:
variant_values = get_variant_values_for(item_details.keys()) variant_values = get_variant_values_for(item_details.keys())
@@ -215,11 +216,14 @@ def get_item_details(items, sle, filters):
return item_details return item_details
def get_item_reorder_details(items): def get_item_reorder_details(items):
item_reorder_details = frappe.db.sql(""" item_reorder_details = frappe._dict()
select parent, warehouse, warehouse_reorder_qty, warehouse_reorder_level
from `tabItem Reorder` if items:
where parent in ({0}) item_reorder_details = frappe.db.sql("""
""".format(', '.join(['"' + frappe.db.escape(i, percent=False) + '"' for i in items])), as_dict=1) select parent, warehouse, warehouse_reorder_qty, warehouse_reorder_level
from `tabItem Reorder`
where parent in ({0})
""".format(', '.join(['"' + frappe.db.escape(i, percent=False) + '"' for i in items])), as_dict=1)
return dict((d.parent + d.warehouse, d) for d in item_reorder_details) return dict((d.parent + d.warehouse, d) for d in item_reorder_details)

5
erpnext/stock/report/stock_ledger/stock_ledger.py
View File

@@ -93,11 +93,14 @@ def get_item_details(items, sl_entries):
if not items: if not items:
items = list(set([d.item_code for d in sl_entries])) items = list(set([d.item_code for d in sl_entries]))
if not items:
return item_details
for item in frappe.db.sql(""" for item in frappe.db.sql("""
select name, item_name, description, item_group, brand, stock_uom select name, item_name, description, item_group, brand, stock_uom
from `tabItem` from `tabItem`
where name in ({0}) where name in ({0})
""".format(', '.join(['"' + frappe.db.escape(i,percent=False) + '"' for i in items])), as_dict=1): """.format(', '.join(['"' + frappe.db.escape(i,percent=False) + '"' for i in items])), as_dict=1, debug=1):
item_details.setdefault(item.name, item) item_details.setdefault(item.name, item)
return item_details return item_details