nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-28 17:34:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Incorrect filters in Voucher Child Table of Land Cost Voucher DocType (#49500)

Browse Source 
* fix: company filter in receipt_document in landed cost voucher

* refactor: use strict equality
This commit is contained in:
Anwar Patel
2025-09-17 17:43:29 +05:30
committed by GitHub
parent 194ab87fef
commit 244dce5098
1 changed files with 12 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js
View File

@@ -5,31 +5,6 @@ frappe.provide("erpnext.stock");
erpnext.landed_cost_taxes_and_charges.setup_triggers("Landed Cost Voucher"); erpnext.landed_cost_taxes_and_charges.setup_triggers("Landed Cost Voucher");
erpnext.stock.LandedCostVoucher = class LandedCostVoucher extends erpnext.stock.StockController { erpnext.stock.LandedCostVoucher = class LandedCostVoucher extends erpnext.stock.StockController {
setup() {
var me = this;
this.frm.fields_dict.purchase_receipts.grid.get_field("receipt_document").get_query = function (
doc,
cdt,
cdn
) {
var d = locals[cdt][cdn];
var filters = [
[d.receipt_document_type, "docstatus", "=", "1"],
[d.receipt_document_type, "company", "=", me.frm.doc.company],
];
if (d.receipt_document_type == "Purchase Invoice") {
filters.push(["Purchase Invoice", "update_stock", "=", "1"]);
}
if (!me.frm.doc.company) frappe.msgprint(__("Please enter company first"));
return {
filters: filters,
};
};
}
refresh() { refresh() {
var help_content = `<br><br> var help_content = `<br><br>
<table class="table table-bordered" style="background-color: var(--scrollbar-track-color);"> <table class="table table-bordered" style="background-color: var(--scrollbar-track-color);">
@@ -158,15 +133,19 @@ frappe.ui.form.on("Landed Cost Voucher", {
setup_queries(frm) { setup_queries(frm) {
frm.set_query("receipt_document", "purchase_receipts", (doc, cdt, cdn) => { frm.set_query("receipt_document", "purchase_receipts", (doc, cdt, cdn) => {
var d = locals[cdt][cdn]; var d = locals[cdt][cdn];
if (d.receipt_document_type === "Stock Entry") { var filters = [
return { [d.receipt_document_type, "docstatus", "=", 1],
filters: { [d.receipt_document_type, "company", "=", frm.doc.company],
docstatus: 1, ];
company: frm.doc.company,
purpose: ["in", ["Manufacture", "Repack"]], if (d.receipt_document_type === "Purchase Invoice") {
}, filters.push(["Purchase Invoice", "update_stock", "=", 1]);
}; } else if (d.receipt_document_type === "Stock Entry") {
filters.push(["Stock Entry", "purpose", "in", ["Manufacture", "Repack"]]);
} }
return {
filters: filters,
};
}); });
frm.set_query("vendor_invoice", "vendor_invoices", (doc, cdt, cdn) => { frm.set_query("vendor_invoice", "vendor_invoices", (doc, cdt, cdn) => {