From 242a119f952adead8074478b772c5ded111a000e Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Tue, 13 May 2025 16:44:13 +0530 Subject: [PATCH] fix: only depreciable category assets are allowed for depreciation (cherry picked from commit d715db1226d83f49644ab5716002cd228d234e16) --- erpnext/assets/doctype/asset/asset.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/erpnext/assets/doctype/asset/asset.py b/erpnext/assets/doctype/asset/asset.py index e1a5398db85..bae6defe6de 100644 --- a/erpnext/assets/doctype/asset/asset.py +++ b/erpnext/assets/doctype/asset/asset.py @@ -122,6 +122,7 @@ class Asset(AccountsController): # end: auto-generated types def validate(self): + self.validate_category() self.validate_precision() self.set_purchase_doc_row_item() self.validate_asset_values() @@ -343,6 +344,17 @@ class Asset(AccountsController): title=_("Missing Finance Book"), ) + def validate_category(self): + non_depreciable_category = frappe.db.get_value( + "Asset Category", self.asset_category, "non_depreciable_category" + ) + if self.calculate_depreciation and non_depreciable_category: + frappe.throw( + _( + "This asset category is marked as non-depreciable. Please disable depreciation calculation or choose a different category." + ) + ) + def validate_precision(self): if self.gross_purchase_amount: self.gross_purchase_amount = flt(