From 23cce731ab9c00c62bcef6bd038cd368c78ec378 Mon Sep 17 00:00:00 2001 From: nabinhait Date: Thu, 3 Jul 2014 12:25:06 +0530 Subject: [PATCH] Fixes in action, not defined if called from outside document class --- erpnext/controllers/accounts_controller.py | 2 +- erpnext/stock/doctype/delivery_note/delivery_note.py | 2 +- erpnext/stock/doctype/packed_item/packed_item.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index aba7a88ae3a..df5370ae19d 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -12,7 +12,7 @@ import json class AccountsController(TransactionBase): def validate(self): - if self._action != "update_after_submit": + if self.get("_action") and self._action != "update_after_submit": self.set_missing_values(for_validate=True) self.validate_date_with_fiscal_year() if self.meta.get_field("currency"): diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.py b/erpnext/stock/doctype/delivery_note/delivery_note.py index 4b147cc3610..c1ddf63a440 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/delivery_note.py @@ -134,7 +134,7 @@ class DeliveryNote(SellingController): def update_current_stock(self): - if self._action != "update_after_submit": + if self.get("_action") and self._action != "update_after_submit": for d in self.get('delivery_note_details'): d.actual_qty = frappe.db.get_value("Bin", {"item_code": d.item_code, "warehouse": d.warehouse}, "actual_qty") diff --git a/erpnext/stock/doctype/packed_item/packed_item.py b/erpnext/stock/doctype/packed_item/packed_item.py index 44c1a00cc9b..f04625b3496 100644 --- a/erpnext/stock/doctype/packed_item/packed_item.py +++ b/erpnext/stock/doctype/packed_item/packed_item.py @@ -62,7 +62,7 @@ def update_packing_list_item(obj, packing_item_code, qty, warehouse, line, packi def make_packing_list(obj, item_table_fieldname): """make packing list for sales bom item""" - if obj._action == "update_after_submit": return + if obj.get("_action") and obj._action == "update_after_submit": return packing_list_idx = 0 parent_items = []