From 36f22f929d784462f3a31754ceb9e8376a986c21 Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 29 Jul 2025 17:39:04 +0530 Subject: [PATCH 1/3] fix: append finance book row only when calculate depreciation is checked --- erpnext/assets/doctype/asset/asset.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erpnext/assets/doctype/asset/asset.py b/erpnext/assets/doctype/asset/asset.py index 019c97114fa..0adf4cc22a3 100644 --- a/erpnext/assets/doctype/asset/asset.py +++ b/erpnext/assets/doctype/asset/asset.py @@ -314,6 +314,9 @@ class Asset(AccountsController): ) def set_missing_values(self): + if not self.calculate_depreciation: + return + if not self.asset_category: self.asset_category = frappe.get_cached_value("Item", self.item_code, "asset_category") @@ -1300,7 +1303,7 @@ def create_new_asset_after_split(asset, split_qty): ) new_asset.insert() - + print(".............") add_asset_activity( new_asset.name, _("Asset created after being split from Asset {0}").format(get_link_to_form("Asset", asset.name)), From 1be071683aaa68c44534d8c37c1baa088c56daa2 Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 29 Jul 2025 17:39:48 +0530 Subject: [PATCH 2/3] test: test assets after split --- erpnext/assets/doctype/asset/test_asset.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/erpnext/assets/doctype/asset/test_asset.py b/erpnext/assets/doctype/asset/test_asset.py index 9c8db82f41b..07dc5c29b2e 100644 --- a/erpnext/assets/doctype/asset/test_asset.py +++ b/erpnext/assets/doctype/asset/test_asset.py @@ -445,6 +445,27 @@ class TestAsset(AssetSetup): self.assertEqual(frappe.db.get_value("Asset", asset.name, "status"), "Sold") + def test_asset_splitting_without_depreciation(self): + asset = create_asset( + calculate_depreciation=0, + asset_quantity=10, + available_for_use_date="2020-01-01", + purchase_date="2020-01-01", + gross_purchase_amount=120000, + submit=1, + ) + + self.assertEqual(asset.asset_quantity, 10) + self.assertEqual(asset.gross_purchase_amount, 120000) + + new_asset = split_asset(asset.name, 2) + asset.load_from_db() + self.assertEqual(asset.asset_quantity, 8) + self.assertEqual(asset.gross_purchase_amount, 96000) + + self.assertEqual(new_asset.asset_quantity, 2) + self.assertEqual(new_asset.gross_purchase_amount, 24000) + def test_asset_splitting(self): asset = create_asset( calculate_depreciation=1, From bc1d3ea01775dc808e024805f2aa929390197d56 Mon Sep 17 00:00:00 2001 From: khushi8112 Date: Tue, 29 Jul 2025 17:43:21 +0530 Subject: [PATCH 3/3] chore: remove print statement --- erpnext/assets/doctype/asset/asset.py | 1 - 1 file changed, 1 deletion(-) diff --git a/erpnext/assets/doctype/asset/asset.py b/erpnext/assets/doctype/asset/asset.py index 0adf4cc22a3..ceb1c46dc6c 100644 --- a/erpnext/assets/doctype/asset/asset.py +++ b/erpnext/assets/doctype/asset/asset.py @@ -1303,7 +1303,6 @@ def create_new_asset_after_split(asset, split_qty): ) new_asset.insert() - print(".............") add_asset_activity( new_asset.name, _("Asset created after being split from Asset {0}").format(get_link_to_form("Asset", asset.name)),