From 20122aef7951968dff29e88c4b5e89095276d4b6 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Fri, 15 Jul 2016 12:42:41 +0530 Subject: [PATCH] [minor] optimize item attribute validation for #5756 --- erpnext/controllers/item_variant.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/controllers/item_variant.py b/erpnext/controllers/item_variant.py index 4f1bb6e027a..3ff3d88050b 100644 --- a/erpnext/controllers/item_variant.py +++ b/erpnext/controllers/item_variant.py @@ -30,11 +30,11 @@ def get_variant(template, args, variant=None): def validate_item_variant_attributes(item, args=None): if not args: - args = {d.attribute:d.attribute_value for d in item.attributes} + args = {d.attribute.lower():d.attribute_value for d in item.attributes} attribute_values = get_attribute_values() - numeric_attributes = frappe._dict({d.attribute: d for d + numeric_attributes = frappe._dict({d.attribute.lower(): d for d in item.attributes if d.numeric_values==1}) for attribute, value in args.items():