nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-15 19:19:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #40494 from ruthra-kumar/bank_statement_import_error

Browse Source 
fix: AttributeError in Bank Statement Import
This commit is contained in:
ruthra kumar
2024-03-17 07:52:19 +05:30
committed by GitHub
parent c46c329ed8 aec630c74f
commit 1fc099dacf
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/accounts/doctype/bank_statement_import/bank_statement_import.py
View File

@@ -149,6 +149,9 @@ def start_import(
import_file = ImportFile("Bank Transaction", file=file, import_type="Insert New Records") import_file = ImportFile("Bank Transaction", file=file, import_type="Insert New Records")
data = parse_data_from_template(import_file.raw_data) data = parse_data_from_template(import_file.raw_data)
# Importer expects 'Data Import' class, which has 'payload_count' attribute
if not data_import.get("payload_count"):
data_import.payload_count = len(data) - 1
if import_file_path: if import_file_path:
add_bank_account(data, bank_account) add_bank_account(data, bank_account)

18
erpnext/accounts/doctype/bank_transaction/bank_transaction.py
View File

@@ -56,17 +56,17 @@ class BankTransaction(Document):
Bank Transaction should be on the same currency as the Bank Account. Bank Transaction should be on the same currency as the Bank Account.
""" """
if self.currency and self.bank_account: if self.currency and self.bank_account:
account = frappe.get_cached_value("Bank Account", self.bank_account, "account") if account := frappe.get_cached_value("Bank Account", self.bank_account, "account"):
account_currency = frappe.get_cached_value("Account", account, "account_currency") account_currency = frappe.get_cached_value("Account", account, "account_currency")
if self.currency != account_currency: if self.currency != account_currency:
frappe.throw( frappe.throw(
_( _(
"Transaction currency: {0} cannot be different from Bank Account({1}) currency: {2}" "Transaction currency: {0} cannot be different from Bank Account({1}) currency: {2}"
).format( ).format(
frappe.bold(self.currency), frappe.bold(self.bank_account), frappe.bold(account_currency) frappe.bold(self.currency), frappe.bold(self.bank_account), frappe.bold(account_currency)
)
) )
)
def set_status(self): def set_status(self):
if self.docstatus == 2: if self.docstatus == 2: